recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix query types on maniphest fulltext search.

Summary:
Parameter `type` is not used anywhere. Instead param `types` is used.
Due this bug search was performed over whole index instead on tasks only.

Test Plan:
- Setup phabricator to run with Elasticsearch.
- Open http://yourphab.com/conduit/method/maniphest.query/
- Fill `fullText` field only.
- Expect get results. Query should be performed on `/phabricator/TASK/` only (not on whole `/phabricator/` index).

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12542

authored by

Povilas Balzaravicius Pawka and committed by
epriestley 7196d29c 6f1b39c0

+2 -1
+2 -1
src/applications/maniphest/query/ManiphestTaskQuery.php
··· 560 560 // NOTE: Setting this to something larger than 2^53 will raise errors in 561 561 // ElasticSearch, and billions of results won't fit in memory anyway. 562 562 $fulltext_query->setParameter('limit', 100000); 563 - $fulltext_query->setParameter('type', ManiphestTaskPHIDType::TYPECONST); 563 + $fulltext_query->setParameter('types', 564 + array(ManiphestTaskPHIDType::TYPECONST)); 564 565 565 566 $engine = PhabricatorSearchEngineSelector::newSelector()->newEngine(); 566 567 $fulltext_results = $engine->executeSearch($fulltext_query);