@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Legalpad - fix a bug for documents with no signatures
Summary: be sure to use array() (and not null) so we don't fatal if we have no signatures
Test Plan: no more fatal when editing a signature-less document
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D8000
+1
-1
+1
-1
src/applications/legalpad/query/LegalpadDocumentQuery.php
+1
-1
src/applications/legalpad/query/LegalpadDocumentQuery.php
···
226
226
$signatures = mgroup($signatures, 'getDocumentPHID');
227
227
228
228
foreach ($documents as $document) {
229
-
$sigs = idx($signatures, $document->getPHID());
229
+
$sigs = idx($signatures, $document->getPHID(), array());
230
230
foreach ($sigs as $index => $sig) {
231
231
if ($sig->getDocumentVersion() != $document->getVersions()) {
232
232
unset($sigs[$index]);