recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Summary: This `%d` should be a `%s`, since the `PhutilNumber` value may get formatted according to locale settings.

Test Plan: will make @zeeg

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D8814

epriestley 71ef48b3 9889892e

+4 -4
+1 -1
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 1070 1070 switch ($strongest->getTransactionType()) { 1071 1071 case DifferentialTransaction::TYPE_UPDATE: 1072 1072 $count = new PhutilNumber($object->getLineCount()); 1073 - $action = pht('%s, %d line(s)', $action, $count); 1073 + $action = pht('%s, %s line(s)', $action, $count); 1074 1074 break; 1075 1075 } 1076 1076
+3 -3
src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php
··· 856 856 '%d older changes are hidden.', 857 857 ), 858 858 859 - '%s, %d line(s)' => array( 860 - '%s, %d line', 861 - '%s, %d lines', 859 + '%s, %s line(s)' => array( 860 + '%s, %s line', 861 + '%s, %s lines', 862 862 ), 863 863 864 864 '%s pushed %d commit(s) to %s.' => array(