@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow device-to-device SSH to establish SSH sessions
Summary:
In D16167 I required users to be logged in to be "activated", but this logic doesn't account for that properly when the user is an Almanac device (a cluster host connecting to another cluster host).
Don't do this check for device connections, they can always establish sessions.
Test Plan: Will push.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D16170
+8
-6
+8
-6
scripts/ssh/ssh-exec.php
+8
-6
scripts/ssh/ssh-exec.php
···
190
190
'P' => $user->getPHID(),
191
191
));
192
192
193
-
if (!$user->canEstablishSSHSessions()) {
194
-
throw new Exception(
195
-
pht(
196
-
'Your account ("%s") does not have permission to establish SSH '.
197
-
'sessions. Visit the web interface for more information.',
198
-
$user_name));
193
+
if (!$device) {
194
+
if (!$user->canEstablishSSHSessions()) {
195
+
throw new Exception(
196
+
pht(
197
+
'Your account ("%s") does not have permission to establish SSH '.
198
+
'sessions. Visit the web interface for more information.',
199
+
$user_name));
200
+
}
199
201
}
200
202
201
203
$workflows = id(new PhutilClassMapQuery())