recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove a check for a non-existing array offset

Summary:
`$style` is never read again in this function, and as the line `'style' => implode(' ', $default_style)` got removed in rPeb73c50e so it can never exist as an array offset.

`DiffusionRepositoryProfilePictureController` is a copy of `PhabricatorPeopleProfilePictureController` so also remove there.

Test Plan: Read the code.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26506

Andre Klapper 747cf0fe 63475357

-8
-4
src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php
··· 147 147 148 148 $buttons = array(); 149 149 foreach ($images as $phid => $spec) { 150 - $style = null; 151 - if (isset($spec['style'])) { 152 - $style = $spec['style']; 153 - } 154 150 $button = javelin_tag( 155 151 'button', 156 152 array(
-4
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
··· 191 191 192 192 $buttons = array(); 193 193 foreach ($images as $phid => $spec) { 194 - $style = null; 195 - if (isset($spec['style'])) { 196 - $style = $spec['style']; 197 - } 198 194 $button = javelin_tag( 199 195 'button', 200 196 array(