@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't send mail to "uninteresting" auditors
Summary:
Fixes T11017. We add packages as "uninteresting" auditors so that we can query commits by package later.
Until recently, this didn't matter because we didn't send mail to packages. But now we do, so stop mailing them when they don't actually need to do anything.
Test Plan:
- Made a commit to a file which was part of a package but which I owned (so it does not trigger auditing).
- `var_dump()`'d mail "To:" PHIDs.
- Before patch: included package.
- After patch: no package.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11017
Differential Revision: https://secure.phabricator.com/D15970
+6
+6
src/applications/audit/editor/PhabricatorAuditEditor.php
+6
src/applications/audit/editor/PhabricatorAuditEditor.php
···
642
642
643
643
$status_resigned = PhabricatorAuditStatusConstants::RESIGNED;
644
644
foreach ($object->getAudits() as $audit) {
645
+
if (!$audit->isInteresting()) {
646
+
// Don't send mail to uninteresting auditors, like packages which
647
+
// own this code but which audits have not triggered for.
648
+
continue;
649
+
}
650
+
645
651
if ($audit->getAuditStatus() != $status_resigned) {
646
652
$phids[] = $audit->getAuditorPHID();
647
653
}