@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Modernize Badges
Summary: Ref T9690, updates Badges in various ways.
Test Plan: View List, View Badge, Create Badge, Assign Badge
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T9690
Differential Revision: https://secure.phabricator.com/D14591
+29
-51
+3
-3
src/applications/almanac/controller/AlmanacServiceViewController.php
+3
-3
src/applications/almanac/controller/AlmanacServiceViewController.php
+6
-7
src/applications/badges/controller/PhabricatorBadgesEditController.php
+6
-7
src/applications/badges/controller/PhabricatorBadgesEditController.php
···
199
199
->setHeaderText($title)
200
200
->appendChild($form);
201
201
202
-
return $this->buildApplicationPage(
203
-
array(
204
-
$crumbs,
205
-
$box,
206
-
),
207
-
array(
208
-
'title' => $title,
202
+
return $this->newPage()
203
+
->setTitle($title)
204
+
->setCrumbs($crumbs)
205
+
->appendChild(
206
+
array(
207
+
$box,
209
208
));
210
209
}
211
210
+7
-8
src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php
+7
-8
src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php
···
106
106
$crumbs->addTextCrumb($badge->getName(), $badge_url);
107
107
$crumbs->addTextCrumb(pht('Recipients'));
108
108
109
-
return $this->buildApplicationPage(
110
-
array(
111
-
$crumbs,
112
-
$form_box,
113
-
$recipient_list,
114
-
),
115
-
array(
116
-
'title' => $title,
109
+
return $this->newPage()
110
+
->setTitle($title)
111
+
->setCrumbs($crumbs)
112
+
->appendChild(
113
+
array(
114
+
$form_box,
115
+
$recipient_list,
117
116
));
118
117
}
119
118
+3
-22
src/applications/badges/controller/PhabricatorBadgesListController.php
+3
-22
src/applications/badges/controller/PhabricatorBadgesListController.php
···
8
8
}
9
9
10
10
public function handleRequest(AphrontRequest $request) {
11
-
$query_key = $request->getURIData('queryKey');
12
-
$controller = id(new PhabricatorApplicationSearchController())
13
-
->setQueryKey($query_key)
14
-
->setSearchEngine(new PhabricatorBadgesSearchEngine())
15
-
->setNavigation($this->buildSideNavView());
16
-
17
-
return $this->delegateToController($controller);
18
-
}
19
-
20
-
public function buildSideNavView() {
21
-
$user = $this->getRequest()->getUser();
22
-
23
-
$nav = new AphrontSideNavFilterView();
24
-
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
25
-
26
-
id(new PhabricatorBadgesSearchEngine())
27
-
->setViewer($user)
28
-
->addNavigationItems($nav->getMenu());
29
-
30
-
$nav->selectFilter(null);
31
-
32
-
return $nav;
11
+
return id(new PhabricatorBadgesSearchEngine())
12
+
->setController($this)
13
+
->buildResponse();
33
14
}
34
15
35
16
protected function buildApplicationCrumbs() {
+10
-11
src/applications/badges/controller/PhabricatorBadgesViewController.php
+10
-11
src/applications/badges/controller/PhabricatorBadgesViewController.php
···
64
64
65
65
$add_comment = $this->buildCommentForm($badge);
66
66
67
-
return $this->buildApplicationPage(
68
-
array(
69
-
$crumbs,
70
-
$box,
71
-
$recipient_list,
72
-
$timeline,
73
-
$add_comment,
74
-
),
75
-
array(
76
-
'title' => $title,
77
-
'pageObjects' => array($badge->getPHID()),
67
+
return $this->newPage()
68
+
->setTitle($title)
69
+
->setCrumbs($crumbs)
70
+
->setPageObjectPHIDs(array($badge->getPHID()))
71
+
->appendChild(
72
+
array(
73
+
$box,
74
+
$recipient_list,
75
+
$timeline,
76
+
$add_comment,
78
77
));
79
78
}
80
79