@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Update import/clear symbols scripts for callsigns

Summary: Ref T4245. Accept identifiers instead of callsigns in these scripts so things continue to work in a future callsign-optional world.

Test Plan: Ran these scripts with both valid and invalid arguments; saw success and errors.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D15300

+18 -14
+9 -7
scripts/symbols/clear_repository_symbols.php
··· 6 6 7 7 $args = new PhutilArgumentParser($argv); 8 8 $args->setSynopsis(<<<EOSYNOPSIS 9 - **clear_repository_symbols.php** [__options__] __callsign__ 9 + **clear_repository_symbols.php** [__options__] __repository__ 10 10 11 11 Clear repository symbols. 12 12 EOSYNOPSIS ··· 15 15 $args->parse( 16 16 array( 17 17 array( 18 - 'name' => 'callsign', 18 + 'name' => 'repository', 19 19 'wildcard' => true, 20 20 ), 21 21 )); 22 22 23 - $callsigns = $args->getArg('callsign'); 24 - if (count($callsigns) !== 1) { 23 + $identifiers = $args->getArg('repository'); 24 + if (count($identifiers) !== 1) { 25 25 $args->printHelpAndExit(); 26 26 } 27 27 28 - $callsign = head($callsigns); 28 + $identifier = head($identifiers); 29 29 $repository = id(new PhabricatorRepositoryQuery()) 30 30 ->setViewer(PhabricatorUser::getOmnipotentUser()) 31 - ->withCallsigns($callsigns) 31 + ->withIdentifiers($identifiers) 32 32 ->executeOne(); 33 33 34 34 if (!$repository) { 35 - echo pht("Repository '%s' does not exist.", $callsign); 35 + echo tsprintf( 36 + "%s\n", 37 + pht('Repository "%s" does not exist.', $identifier)); 36 38 exit(1); 37 39 } 38 40
+9 -7
scripts/symbols/import_repository_symbols.php
··· 6 6 7 7 $args = new PhutilArgumentParser($argv); 8 8 $args->setSynopsis(<<<EOSYNOPSIS 9 - **import_repository_symbols.php** [__options__] __callsign__ < symbols 9 + **import_repository_symbols.php** [__options__] __repository__ < symbols 10 10 11 11 Import repository symbols (symbols are read from stdin). 12 12 EOSYNOPSIS ··· 35 35 'be part of a single transaction.'), 36 36 ), 37 37 array( 38 - 'name' => 'callsign', 38 + 'name' => 'repository', 39 39 'wildcard' => true, 40 40 ), 41 41 )); 42 42 43 - $callsigns = $args->getArg('callsign'); 44 - if (count($callsigns) !== 1) { 43 + $identifiers = $args->getArg('repository'); 44 + if (count($identifiers) !== 1) { 45 45 $args->printHelpAndExit(); 46 46 } 47 47 48 - $callsign = head($callsigns); 48 + $identifier = head($identifiers); 49 49 $repository = id(new PhabricatorRepositoryQuery()) 50 50 ->setViewer(PhabricatorUser::getOmnipotentUser()) 51 - ->withCallsigns($callsigns) 51 + ->withIdentifiers($identifiers) 52 52 ->executeOne(); 53 53 54 54 if (!$repository) { 55 - echo pht("Repository '%s' does not exist.", $callsign); 55 + echo tsprintf( 56 + "%s\n", 57 + pht('Repository "%s" does not exist.', $identifier)); 56 58 exit(1); 57 59 } 58 60