@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an email address validation UI feedback issue when creating new users
Summary: On the "New User" web workflow, if you use an invalid email address, you get a failure with an empty message.
Test Plan:
- Before: Tried to create a new user with address "asdf". Got no specific guidance.
- After: Got specific guidance about email address formatting and length.
Differential Revision: https://secure.phabricator.com/D21264
+4
-1
+4
-1
src/applications/people/controller/PhabricatorPeopleNewController.php
+4
-1
src/applications/people/controller/PhabricatorPeopleNewController.php
···
50
50
if (!strlen($new_email)) {
51
51
$errors[] = pht('Email is required.');
52
52
$e_email = pht('Required');
53
+
} else if (!PhabricatorUserEmail::isValidAddress($new_email)) {
54
+
$errors[] = PhabricatorUserEmail::describeValidAddresses();
55
+
$e_email = pht('Invalid');
53
56
} else if (!PhabricatorUserEmail::isAllowedAddress($new_email)) {
54
-
$e_email = pht('Invalid');
55
57
$errors[] = PhabricatorUserEmail::describeAllowedAddresses();
58
+
$e_email = pht('Not Allowed');
56
59
} else {
57
60
$e_email = null;
58
61
}