@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Change "Revision Close" story to use commit identities only with no fallback to commit data
Summary:
See PHI1213. If we don't have identities for "revision X closed by commit Y" stories, just do the plain non-attribution rendering rather than trying to fall back. Falling back won't work since we don't load the data, which should be OK now since identities seem like they're in generally good shape.
(We could probably just throw out the fallback behavior instead, but we can always clean things up later.)
Test Plan: Forced no commit identity on a revision, loaded it, saw reasonable story rendering.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20460
+11
-2
+11
-2
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+11
-2
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
···
100
100
$this->renderAuthor());
101
101
}
102
102
103
-
$author_phid = $commit->getAuthorDisplayPHID();
104
-
$committer_phid = $commit->getCommitterDisplayPHID();
103
+
$author_phid = null;
104
+
if ($commit->hasAuthorIdentity()) {
105
+
$identity = $commit->getAuthorIdentity();
106
+
$author_phid = $identity->getIdentityDisplayPHID();
107
+
}
108
+
109
+
$committer_phid = null;
110
+
if ($commit->hasCommitterIdentity()) {
111
+
$identity = $commit->getCommitterIdentity();
112
+
$committer_phid = $identity->getIdentityDisplayPHID();
113
+
}
105
114
106
115
if (!$author_phid) {
107
116
return pht(