@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Conpherence - fix durable column message duplicating bug

Summary: Fixes T6713. Though I've said that before. =D Looks like this handler wasn't upgraded earlier and was still updating the DOM; removing the DOM updating code and let the central spot handle everything and this works fine.

Test Plan: open up two browsers with durable column on same room. send messages in browser a and observe 1 copy of each message showing up in browser b. send messages in browswer b and observe one copy in browser a. browser a was chrome and browser b was firefox.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T6713

Differential Revision: https://secure.phabricator.com/D13214

+13 -14
+13 -13
resources/celerity/map.php
··· 8 8 return array( 9 9 'names' => array( 10 10 'core.pkg.css' => 'd7ecac6d', 11 - 'core.pkg.js' => '3bbe23c6', 11 + 'core.pkg.js' => '288f6571', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '02273347', 14 14 'differential.pkg.js' => 'ebef29b1', ··· 337 337 'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408', 338 338 'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2', 339 339 'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a', 340 - 'rsrc/js/application/conpherence/behavior-durable-column.js' => '16c695bf', 340 + 'rsrc/js/application/conpherence/behavior-durable-column.js' => 'c72aa091', 341 341 'rsrc/js/application/conpherence/behavior-menu.js' => '43b24a10', 342 342 'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861', 343 343 'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3', ··· 574 574 'javelin-behavior-diffusion-locate-file' => '6d3e1947', 575 575 'javelin-behavior-diffusion-pull-lastmodified' => '2b228192', 576 576 'javelin-behavior-doorkeeper-tag' => 'e5822781', 577 - 'javelin-behavior-durable-column' => '16c695bf', 577 + 'javelin-behavior-durable-column' => 'c72aa091', 578 578 'javelin-behavior-error-log' => '6882e80a', 579 579 'javelin-behavior-event-all-day' => '38dcf3c8', 580 580 'javelin-behavior-fancy-datepicker' => '510b5809', ··· 950 950 'javelin-request', 951 951 'javelin-util', 952 952 ), 953 - '16c695bf' => array( 954 - 'javelin-behavior', 955 - 'javelin-dom', 956 - 'javelin-stratcom', 957 - 'javelin-behavior-device', 958 - 'javelin-scrollbar', 959 - 'javelin-quicksand', 960 - 'phabricator-keyboard-shortcut', 961 - 'conpherence-thread-manager', 962 - ), 963 953 '1ad0a787' => array( 964 954 'javelin-install', 965 955 'javelin-reactor', ··· 1800 1790 'javelin-stratcom', 1801 1791 'javelin-dom', 1802 1792 'javelin-vector', 1793 + ), 1794 + 'c72aa091' => array( 1795 + 'javelin-behavior', 1796 + 'javelin-dom', 1797 + 'javelin-stratcom', 1798 + 'javelin-behavior-device', 1799 + 'javelin-scrollbar', 1800 + 'javelin-quicksand', 1801 + 'phabricator-keyboard-shortcut', 1802 + 'conpherence-thread-manager', 1803 1803 ), 1804 1804 'c8e57404' => array( 1805 1805 'javelin-behavior',
-1
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
··· 143 143 }); 144 144 threadManager.setDidUpdateThreadCallback(function(r) { 145 145 var messages = _getColumnMessagesNode(); 146 - JX.DOM.appendContent(messages, JX.$H(r.transactions)); 147 146 scrollbar.scrollTo(messages.scrollHeight); 148 147 }); 149 148