@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't throw an exception if the author of a tag can't be found
Summary:
It's possible to have a tag with no tagger (or git used to allow this),
so some tags (like 26791a8bcf0e6d33f43aef7682bdb555236d56de in the linux
kernel) were causing trouble.
Test Plan:
opened diffusion to a page where I was previously getting a red box complaining
about being unable to parse the output of git for-each-ref.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin, vrana
Differential Revision: https://secure.phabricator.com/D2711
+6
-5
+6
-5
src/applications/diffusion/query/taglist/DiffusionGitTagListQuery.php
+6
-5
src/applications/diffusion/query/taglist/DiffusionGitTagListQuery.php
···
49
49
50
50
$matches = null;
51
51
if (!preg_match('/^(.*) ([0-9]+) ([0-9+-]+)$/', $creator, $matches)) {
52
-
throw new Exception(
53
-
"Unparseable output from 'git for-each-ref': {$line}");
52
+
// It's possible a tag doesn't have a creator (tagger)
53
+
$author = null;
54
+
$epoch = null;
55
+
} else {
56
+
$author = $matches[1];
57
+
$epoch = $matches[2];
54
58
}
55
-
56
-
$author = $matches[1];
57
-
$epoch = $matches[2];
58
59
59
60
$tag = new DiffusionRepositoryTag();
60
61
$tag->setAuthor($author);