recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes

Summary: Ref T13303. I upgraded this to a vector-based sort but forgot to type a "v", which means the sort has different stability under PHP 5.5. See D20582 for a root cause fix.

Test Plan: Locally, on PHP7, not much changes. I expect this to fix the odd selection of title stories in mail and notification stories on `secure`, which is running PHP 5.5.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13303

Differential Revision: https://secure.phabricator.com/D20583

epriestley 874282db d3112392

+1 -1
+1 -1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 3267 3267 protected function getStrongestAction( 3268 3268 PhabricatorLiskDAO $object, 3269 3269 array $xactions) { 3270 - return head(msort($xactions, 'newActionStrengthSortVector')); 3270 + return head(msortv($xactions, 'newActionStrengthSortVector')); 3271 3271 } 3272 3272 3273 3273