-1

src/applications/config/option/PhabricatorConfigOption.php

reviewed

··· 207 207 /** 208 208 * Get the type key. 209 209 * 210 210 - * @param string $type Type key. 211 210 * @return string|null 212 211 */ 213 212 public function getType() {

+2 -2

src/applications/differential/parser/DifferentialHunkParser.php

reviewed

··· 673 673 } 674 674 675 675 /** 676 676 - * @param array<DifferentialHunk> $new_hunks 676 676 + * @param array<DifferentialHunk> $hunks 677 677 * @param bool $is_new 678 678 * @param int $line_number 679 679 * @param int $line_length ··· 766 766 } 767 767 768 768 /** 769 769 - * @param array<DifferentialHunk> $new_hunks 769 769 + * @param array<DifferentialHunk> $hunks 770 770 */ 771 771 private function computeOffsets(array $hunks) { 772 772 assert_instances_of($hunks, DifferentialHunk::class);

+6 -3

src/applications/maniphest/xaction/ManiphestTaskAttachTransaction.php

reviewed

··· 1 1 <?php 2 2 3 3 + /* 4 4 + * This transaction type is deprecated. We keep it around for legacy installs 5 5 + * so any transactions render correctly. 6 6 + * 7 7 + * @deprecated 8 8 + */ 3 9 final class ManiphestTaskAttachTransaction 4 10 extends ManiphestTaskTransactionType { 5 5 - 6 6 - // NOTE: this type is deprecated. Keep it around for legacy installs 7 7 - // so any transactions render correctly. 8 11 9 12 const TRANSACTIONTYPE = 'attach'; 10 13

+1 -1

src/applications/search/menuitem/PhabricatorProfileMenuItem.php

reviewed

··· 77 77 78 78 /** 79 79 * @param PhabricatorProfileMenuItemConfiguration $config 80 80 - * @param array<PhabricatorProfileMenuItemView> $list 80 80 + * @return array<PhabricatorProfileMenuItemView> 81 81 */ 82 82 final public function getMenuItemViewList( 83 83 PhabricatorProfileMenuItemConfiguration $config) {

+8

src/view/phui/PHUIButtonView.php

reviewed

··· 81 81 return $this; 82 82 } 83 83 84 84 + /** 85 85 + * Set the HTML tag for the button, e.g. 'button', 'input', 'a'. 86 86 + * @param string $tag 87 87 + */ 84 88 public function setTag($tag) { 85 89 $this->tag = $tag; 86 90 return $this; ··· 147 151 return $this; 148 152 } 149 153 154 154 + /** 155 155 + * Get the HTML tag set for the button, e.g. 'button', 'input', 'a'. 156 156 + * @return string 157 157 + */ 150 158 protected function getTagName() { 151 159 return $this->tag; 152 160 }

+4

src/view/phui/PHUIHeaderView.php

reviewed

··· 168 168 return $this->href; 169 169 } 170 170 171 171 + /** 172 172 + * Get the HTML tag 173 173 + * @return string 174 174 + */ 171 175 protected function getTagName() { 172 176 if ($this->collapsible) { 173 177 return 'summary';