@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
render_tag -> tag: misc views
Summary: See inlines.
Test Plan: See inlines.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4768
+52
-29
+9
-1
src/applications/conpherence/view/ConpherenceMenuItemView.php
+9
-1
src/applications/conpherence/view/ConpherenceMenuItemView.php
+7
-6
src/applications/directory/controller/PhabricatorDirectoryController.php
+7
-6
src/applications/directory/controller/PhabricatorDirectoryController.php
···
96
96
97
97
$nav->addMenuItem($show_item);
98
98
$nav->addCustomBlock(
99
-
'<div '.
100
-
'id="'.phutil_escape_html($show_tiles_id).'"'.
101
-
'style="display: none;">');
99
+
hsprintf(
100
+
'<div id="%s" style="display: none;">',
101
+
$show_tiles_id));
102
102
103
103
Javelin::initBehavior('phabricator-home-reveal-tiles', array(
104
104
'tilesID' => $show_tiles_id,
···
128
128
}
129
129
$nav->addLabel($groups[$group]);
130
130
}
131
+
131
132
$nav->addCustomBlock(
132
-
phutil_render_tag(
133
+
phutil_tag(
133
134
'div',
134
135
array(
135
136
'class' => 'application-tile-group',
136
137
),
137
-
id(new AphrontNullView())->appendChild($tiles)->render()));
138
+
mpull($tiles, 'render')));
138
139
}
139
140
140
141
$is_hide = ($tile_display == PhabricatorApplication::TILE_HIDE);
141
142
if ($is_hide) {
142
143
$nav->addMenuItem($hide_item);
143
-
$nav->addCustomBlock('</div>');
144
+
$nav->addCustomBlock(hsprintf('</div>'));
144
145
}
145
146
}
146
147
+2
-2
src/view/AphrontTagView.php
+2
-2
src/view/AphrontTagView.php
···
87
87
}
88
88
89
89
protected function getTagContent() {
90
-
return $this->renderChildren();
90
+
return $this->renderHTMLChildren();
91
91
}
92
92
93
93
protected function willRender() {
···
150
150
}
151
151
}
152
152
153
-
return javelin_render_tag(
153
+
return javelin_tag(
154
154
$this->getTagName(),
155
155
$attributes,
156
156
$this->getTagContent());
+17
-10
src/view/control/PhabricatorObjectListView.php
+17
-10
src/view/control/PhabricatorObjectListView.php
···
26
26
foreach ($handles as $handle) {
27
27
$buttons = idx($this->buttons, $handle->getPHID(), array());
28
28
if ($buttons) {
29
-
$buttons =
30
-
'<div class="phabricator-object-list-view-buttons">'.
31
-
implode('', $buttons).
32
-
'</div>';
29
+
$buttons = phutil_tag(
30
+
'div',
31
+
array(
32
+
'class' => 'phabricator-object-list-view-buttons',
33
+
),
34
+
$buttons);
33
35
} else {
34
36
$buttons = null;
35
37
}
36
38
37
-
$out[] = javelin_render_tag(
39
+
$out[] = javelin_tag(
38
40
'div',
39
41
array(
40
42
'class' => 'phabricator-object-list-view-item',
41
43
'style' => 'background-image: url('.$handle->getImageURI().');',
42
44
),
43
-
$handle->renderLink().$buttons);
45
+
array(
46
+
$handle->renderLink(),
47
+
$buttons,
48
+
));
44
49
}
45
50
46
-
return
47
-
'<div class="phabricator-object-list-view">'.
48
-
implode("\n", $out).
49
-
'</div>';
51
+
return phutil_tag(
52
+
'div',
53
+
array(
54
+
'class' => 'phabricator-object-list-view',
55
+
),
56
+
$out);
50
57
}
51
58
52
59
}