@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "DifferentialParentRevisionsField" custom field
Summary: Ref T11114. This was obsoleted by UI changes and hacked around for performance in T11404. It no longer does anything.
Test Plan: Grepped for removed class name.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17077
-47
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
473
473
'DifferentialMailView' => 'applications/differential/mail/DifferentialMailView.php',
474
474
'DifferentialManiphestTasksField' => 'applications/differential/customfield/DifferentialManiphestTasksField.php',
475
475
'DifferentialModernHunk' => 'applications/differential/storage/DifferentialModernHunk.php',
476
-
'DifferentialParentRevisionsField' => 'applications/differential/customfield/DifferentialParentRevisionsField.php',
477
476
'DifferentialParseCacheGarbageCollector' => 'applications/differential/garbagecollector/DifferentialParseCacheGarbageCollector.php',
478
477
'DifferentialParseCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php',
479
478
'DifferentialParseRenderTestCase' => 'applications/differential/__tests__/DifferentialParseRenderTestCase.php',
···
5127
5126
'DifferentialMailView' => 'Phobject',
5128
5127
'DifferentialManiphestTasksField' => 'DifferentialCoreCustomField',
5129
5128
'DifferentialModernHunk' => 'DifferentialHunk',
5130
-
'DifferentialParentRevisionsField' => 'DifferentialCustomField',
5131
5129
'DifferentialParseCacheGarbageCollector' => 'PhabricatorGarbageCollector',
5132
5130
'DifferentialParseCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
5133
5131
'DifferentialParseRenderTestCase' => 'PhabricatorTestCase',
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-44
src/applications/differential/customfield/DifferentialParentRevisionsField.php
-44
src/applications/differential/customfield/DifferentialParentRevisionsField.php
···
1
-
<?php
2
-
3
-
final class DifferentialParentRevisionsField
4
-
extends DifferentialCustomField {
5
-
6
-
public function getFieldKey() {
7
-
return 'differential:depends-on';
8
-
}
9
-
10
-
public function getFieldName() {
11
-
return pht('Parent Revisions');
12
-
}
13
-
14
-
public function canDisableField() {
15
-
return false;
16
-
}
17
-
18
-
public function getFieldDescription() {
19
-
return pht('Lists revisions this one depends on.');
20
-
}
21
-
22
-
public function getProTips() {
23
-
return array(
24
-
pht(
25
-
'Create a dependency between revisions by writing '.
26
-
'"%s" in your summary.',
27
-
'Depends on D123'),
28
-
);
29
-
}
30
-
31
-
public function shouldAppearInConduitDictionary() {
32
-
// To improve performance, we exclude this field from Conduit results.
33
-
// See T11404 for discussion. In modern "differential.revision.search",
34
-
// this information is available efficiently as an attachment.
35
-
return false;
36
-
}
37
-
38
-
public function getConduitDictionaryValue() {
39
-
return PhabricatorEdgeQuery::loadDestinationPHIDs(
40
-
$this->getObject()->getPHID(),
41
-
DifferentialRevisionDependsOnRevisionEdgeType::EDGECONST);
42
-
}
43
-
44
-
}