@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "Next Step" Differential custom field
Summary: Ref T12027. This is purely a UI hint for new users that I'd like to integrate into "Land Revision" in the future instead.
Test Plan: Grepped for removed class, browsed Differential.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12027
Differential Revision: https://secure.phabricator.com/D17076
-69
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
473
473
'DifferentialMailView' => 'applications/differential/mail/DifferentialMailView.php',
474
474
'DifferentialManiphestTasksField' => 'applications/differential/customfield/DifferentialManiphestTasksField.php',
475
475
'DifferentialModernHunk' => 'applications/differential/storage/DifferentialModernHunk.php',
476
-
'DifferentialNextStepField' => 'applications/differential/customfield/DifferentialNextStepField.php',
477
476
'DifferentialParentRevisionsField' => 'applications/differential/customfield/DifferentialParentRevisionsField.php',
478
477
'DifferentialParseCacheGarbageCollector' => 'applications/differential/garbagecollector/DifferentialParseCacheGarbageCollector.php',
479
478
'DifferentialParseCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php',
···
5128
5127
'DifferentialMailView' => 'Phobject',
5129
5128
'DifferentialManiphestTasksField' => 'DifferentialCoreCustomField',
5130
5129
'DifferentialModernHunk' => 'DifferentialHunk',
5131
-
'DifferentialNextStepField' => 'DifferentialCustomField',
5132
5130
'DifferentialParentRevisionsField' => 'DifferentialCustomField',
5133
5131
'DifferentialParseCacheGarbageCollector' => 'PhabricatorGarbageCollector',
5134
5132
'DifferentialParseCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
-2
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-2
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-65
src/applications/differential/customfield/DifferentialNextStepField.php
-65
src/applications/differential/customfield/DifferentialNextStepField.php
···
1
-
<?php
2
-
3
-
final class DifferentialNextStepField
4
-
extends DifferentialCustomField {
5
-
6
-
public function getFieldKey() {
7
-
return 'differential:next-step';
8
-
}
9
-
10
-
public function getFieldName() {
11
-
return pht('Next Step');
12
-
}
13
-
14
-
public function getFieldDescription() {
15
-
return pht('Provides a hint for the next step to take.');
16
-
}
17
-
18
-
public function shouldAppearInPropertyView() {
19
-
return true;
20
-
}
21
-
22
-
public function renderPropertyViewLabel() {
23
-
return $this->getFieldName();
24
-
}
25
-
26
-
public function renderPropertyViewValue(array $handles) {
27
-
$revision = $this->getObject();
28
-
$diff = $revision->getActiveDiff();
29
-
30
-
$status = $revision->getStatus();
31
-
if ($status != ArcanistDifferentialRevisionStatus::ACCEPTED) {
32
-
return null;
33
-
}
34
-
35
-
$local_vcs = $diff->getSourceControlSystem();
36
-
switch ($local_vcs) {
37
-
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
38
-
$bookmark = $diff->getBookmark();
39
-
if (strlen($bookmark)) {
40
-
$next_step = csprintf('arc land %R', $bookmark);
41
-
} else {
42
-
$next_step = csprintf('arc land');
43
-
}
44
-
break;
45
-
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
46
-
$branch = $diff->getBranch();
47
-
if (strlen($branch)) {
48
-
$next_step = csprintf('arc land %R', $branch);
49
-
} else {
50
-
$next_step = csprintf('arc land');
51
-
}
52
-
break;
53
-
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
54
-
$next_step = csprintf('arc commit');
55
-
break;
56
-
default:
57
-
return null;
58
-
}
59
-
60
-
$next_step = phutil_tag('tt', array(), (string)$next_step);
61
-
62
-
return $next_step;
63
-
}
64
-
65
-
}