@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
More correct fix - set default value array() for `getParameter` call.
Summary: Ref T8577, More correct fix - set default value array() for `getParameter` call.
Test Plan: Make sure saved queries like Month View, Day View, and Upcoming Events, still work.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin
Maniphest Tasks: T8577
Differential Revision: https://secure.phabricator.com/D13330
+4
-4
+4
-4
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+4
-4
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
···
126
126
$query->withDateRange($min_range, $max_range);
127
127
}
128
128
129
-
$invited_phids = $saved->getParameter('invitedPHIDs');
129
+
$invited_phids = $saved->getParameter('invitedPHIDs', array());
130
+
$invited_phids = $user_datasource->evaluateTokens($invited_phids);
130
131
if ($invited_phids) {
131
-
$invited_phids = $user_datasource->evaluateTokens($invited_phids);
132
132
$query->withInvitedPHIDs($invited_phids);
133
133
}
134
134
135
-
$creator_phids = $saved->getParameter('creatorPHIDs');
135
+
$creator_phids = $saved->getParameter('creatorPHIDs', array());
136
+
$creator_phids = $user_datasource->evaluateTokens($creator_phids);
136
137
if ($creator_phids) {
137
-
$creator_phids = $user_datasource->evaluateTokens($creator_phids);
138
138
$query->withCreatorPHIDs($creator_phids);
139
139
}
140
140