@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Dashboard Tabs: fix action "Move Right"
Summary:
It seems that if you use the "Move Right" action, you can get
an unrelated error message about "Move Left":
This is already the first tab. It can not move any farther to the left.
This happened because there was an incomplete condition.
Closes T15493
Test Plan:
- visit /dashboard/panel/ and create at least two panels (please, owned by you)
- visit a Dashboard, and add a Tabs Panel
- take the first Tab: "Move Right"
After this change, "Move Right" now always works.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: speck, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15493
Differential Revision: https://we.phorge.it/D25307
+1
-1
+1
-1
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
+1
-1
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
···
327
327
'This is already the last tab. It can not move any farther to '.
328
328
'the right.'))
329
329
->addCancelButton($cancel_uri);
330
-
} else if ((string)head_key($old_config) === $target) {
330
+
} else if (!$is_next && (string)head_key($old_config) === $target) {
331
331
return $this->newDialog()
332
332
->setTitle(pht('Impossible!'))
333
333
->appendParagraph(