recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a warning in BoardLayoutEngine when no objects are being updated

Summary: Fixes T13368. Some workflows (like "Move tasks to...") execute board layout without objects to update. In these cases, we can hit a warning because `objectPHIDs` is not initialized to `array()`.

Test Plan: Went through the "Move tasks to..." workflow on a workboard, no longer saw a warning when trying to iterate over an empty `objectPHIDs` list.

Maniphest Tasks: T13368

Differential Revision: https://secure.phabricator.com/D20701

epriestley 937edcdc 0561043a

+1 -1
+1 -1
src/applications/project/engine/PhabricatorBoardLayoutEngine.php
··· 4 4 5 5 private $viewer; 6 6 private $boardPHIDs; 7 - private $objectPHIDs; 7 + private $objectPHIDs = array(); 8 8 private $boards; 9 9 private $columnMap = array(); 10 10 private $objectColumnMap = array();