@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update a factor query in TransactionEditor for providers
Summary: This query didn't get updated and could let you through an explicit "Sign with MFA" action if you have only disabled factors on your account.
Test Plan:
- Disabled all factors.
- Used explicit "Sign With MFA".
- Before: Went through.
- After: Sensible error.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20072
+9
-3
+9
-3
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+9
-3
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
2669
2669
$transaction_type) {
2670
2670
$errors = array();
2671
2671
2672
-
$factors = id(new PhabricatorAuthFactorConfig())->loadAllWhere(
2673
-
'userPHID = %s',
2674
-
$this->getActingAsPHID());
2672
+
$factors = id(new PhabricatorAuthFactorConfigQuery())
2673
+
->setViewer($this->getActor())
2674
+
->withUserPHIDs(array($this->getActingAsPHID()))
2675
+
->withFactorProviderStatuses(
2676
+
array(
2677
+
PhabricatorAuthFactorProviderStatus::STATUS_ACTIVE,
2678
+
PhabricatorAuthFactorProviderStatus::STATUS_DEPRECATED,
2679
+
))
2680
+
->execute();
2675
2681
2676
2682
foreach ($xactions as $xaction) {
2677
2683
if (!$factors) {