@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix return values in PhutilKeyValueCacheStack
Summary:
`PhutilKeyValueCacheStack::setKeys()`, `PhutilKeyValueCacheStack::deleteKeys()`, `PhutilKeyValueCacheStack::destroyCache()` are all supposed to return `$this` like all other implementations of the methods in parent class `PhutilKeyValueCache` already do.
Thus add missing return statements.
Test Plan: Run static code analysis, don't get a complaint about a missing return value anymore.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26093
+3
+3
src/infrastructure/cache/PhutilKeyValueCacheStack.php
+3
src/infrastructure/cache/PhutilKeyValueCacheStack.php
···
113
113
foreach ($this->cachesBackward as $cache) {
114
114
$cache->setKeys($keys, $ttl);
115
115
}
116
+
return $this;
116
117
}
117
118
118
119
···
120
121
foreach ($this->cachesBackward as $cache) {
121
122
$cache->deleteKeys($keys);
122
123
}
124
+
return $this;
123
125
}
124
126
125
127
···
127
129
foreach ($this->cachesBackward as $cache) {
128
130
$cache->destroyCache();
129
131
}
132
+
return $this;
130
133
}
131
134
132
135
}