@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a couple of column editing issues
Summary:
Ref T10349.
- Don't show subproject columns on "Manage Board".
- Fix "Edit Column" for milestone columns (allows you to set points, but not rename).
Test Plan:
- Viewed "Manage Board" on a project with subprojects.
- Edited a milestone column and set a point limit.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10349
Differential Revision: https://secure.phabricator.com/D15338
+9
-2
+5
src/applications/project/controller/PhabricatorProjectBoardManageController.php
+5
src/applications/project/controller/PhabricatorProjectBoardManageController.php
···
152
152
foreach ($columns as $column) {
153
153
$column_id = $column->getID();
154
154
155
+
$proxy = $column->getProxy();
156
+
if ($proxy && !$proxy->isMilestone()) {
157
+
continue;
158
+
}
159
+
155
160
$detail_uri = "/project/board/{$board_id}/column/{$column_id}/";
156
161
157
162
$item = id(new PHUIObjectItemView())
+4
-2
src/applications/project/controller/PhabricatorProjectColumnEditController.php
+4
-2
src/applications/project/controller/PhabricatorProjectColumnEditController.php
···
81
81
82
82
$xactions = array();
83
83
84
+
$type_name = PhabricatorProjectColumnTransaction::TYPE_NAME;
85
+
$type_limit = PhabricatorProjectColumnTransaction::TYPE_LIMIT;
86
+
84
87
if (!$column->getProxy()) {
85
-
$type_name = PhabricatorProjectColumnTransaction::TYPE_NAME;
86
88
$xactions[] = id(new PhabricatorProjectColumnTransaction())
87
89
->setTransactionType($type_name)
88
90
->setNewValue($v_name);
89
91
}
90
92
91
-
$type_limit = PhabricatorProjectColumnTransaction::TYPE_LIMIT;
92
93
$xactions[] = id(new PhabricatorProjectColumnTransaction())
93
94
->setTransactionType($type_limit)
94
95
->setNewValue($v_limit);
···
97
98
$editor = id(new PhabricatorProjectColumnTransactionEditor())
98
99
->setActor($viewer)
99
100
->setContinueOnNoEffect(true)
101
+
->setContinueOnMissingFields(true)
100
102
->setContentSourceFromRequest($request)
101
103
->applyTransactions($column, $xactions);
102
104
return id(new AphrontRedirectResponse())->setURI($view_uri);