recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Sort milestones by milestone number, not ID

Summary: Ref T10350. Normally, milestone numbers and IDs have the same order, but they may not if you used the script in T10350 to artificially move a bunch of stuff around.

Test Plan: Milestones now go "1, 2, <thing I artifically moved into position 3>" on local install.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10350

Differential Revision: https://secure.phabricator.com/D15266

epriestley 9bab3c25 bec21d80

+7 -2
+1 -1
src/applications/project/controller/PhabricatorProjectProfileController.php
··· 205 205 array( 206 206 PhabricatorProjectStatus::STATUS_ACTIVE, 207 207 )) 208 - ->setOrder('newest') 208 + ->setOrderVector(array('milestoneNumber', 'id')) 209 209 ->execute(); 210 210 if (!$milestones) { 211 211 return null;
+1 -1
src/applications/project/controller/PhabricatorProjectSubprojectsController.php
··· 43 43 ->withParentProjectPHIDs(array($project->getPHID())) 44 44 ->needImages(true) 45 45 ->withIsMilestone(true) 46 - ->setOrder('newest') 46 + ->setOrderVector(array('milestoneNumber', 'id')) 47 47 ->execute(); 48 48 } else { 49 49 $milestones = array();
+5
src/applications/project/query/PhabricatorProjectQuery.php
··· 170 170 'type' => 'string', 171 171 'unique' => true, 172 172 ), 173 + 'milestoneNumber' => array( 174 + 'table' => $this->getPrimaryTableAlias(), 175 + 'column' => 'milestoneNumber', 176 + 'type' => 'int', 177 + ), 173 178 ); 174 179 } 175 180