@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix information page about Read-only status
Summary:
This change fixes the following page on your Phorge/Phabricator:
/readonly/config/
If you visit that page (with or without read-only mode), the
following crash will happen:
Call to undefined method PlatformSymbols::getPlatformServerSymbol()
Fixes T15185
Probably the regression was introduced in this point:
rP4d3f0dc7c727e6fdc0e8cba0e8e8f2b8ef1bd16c
This change also renamed "administrator" to "Administrator" in the messages
from that specific page, both because I have great respect for Administrators
and also because that is how this word is spelled in most other places in Phorge.
Test Plan:
- Visit the page /readonly/config/
- It does not crash anymore and you can see that beautiful message
that - it seems - no person in the world has ever seen since a
whole year. Take a good look at this page: it is a precious treasure.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: speck, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15185
Differential Revision: https://we.phorge.it/D25091
+44
-44
+41
-41
resources/celerity/map.php
+41
-41
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => '0e3cf785',
11
11
'conpherence.pkg.js' => '020aebcf',
12
12
'core.pkg.css' => 'f538846d',
13
-
'core.pkg.js' => '6a2c22c2',
13
+
'core.pkg.js' => '66c49ca1',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '609e63d4',
16
16
'differential.pkg.js' => 'c60bec1b',
···
257
257
'rsrc/externals/javelin/lib/URI.js' => '2e255291',
258
258
'rsrc/externals/javelin/lib/Vector.js' => 'e9c80beb',
259
259
'rsrc/externals/javelin/lib/WebSocket.js' => 'fdc13e4e',
260
-
'rsrc/externals/javelin/lib/Workflow.js' => 'd7ba6915',
260
+
'rsrc/externals/javelin/lib/Workflow.js' => 'cc1553f3',
261
261
'rsrc/externals/javelin/lib/__tests__/Cookie.js' => 'ca686f71',
262
262
'rsrc/externals/javelin/lib/__tests__/DOM.js' => '4566e249',
263
263
'rsrc/externals/javelin/lib/__tests__/JSON.js' => '710377ae',
···
265
265
'rsrc/externals/javelin/lib/__tests__/behavior.js' => '8426ebeb',
266
266
'rsrc/externals/javelin/lib/behavior.js' => '1b6acc2a',
267
267
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => '89a1ae3a',
268
-
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => 'd96e47a4',
268
+
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => '0507519c',
269
269
'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => 'a241536a',
270
270
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '22ee68a5',
271
271
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '23387297',
···
423
423
'rsrc/js/application/projects/WorkboardCard.js' => '0392a5d8',
424
424
'rsrc/js/application/projects/WorkboardCardTemplate.js' => '84f82dad',
425
425
'rsrc/js/application/projects/WorkboardColumn.js' => 'c3d24e63',
426
-
'rsrc/js/application/projects/WorkboardController.js' => 'b9d0c2f3',
426
+
'rsrc/js/application/projects/WorkboardController.js' => '7474d31f',
427
427
'rsrc/js/application/projects/WorkboardDropEffect.js' => '8e0aa661',
428
428
'rsrc/js/application/projects/WorkboardHeader.js' => '111bfd2d',
429
429
'rsrc/js/application/projects/WorkboardHeaderTemplate.js' => 'ebe83a6b',
···
453
453
'rsrc/js/core/DragAndDropFileUpload.js' => '4370900d',
454
454
'rsrc/js/core/DraggableList.js' => '0169e425',
455
455
'rsrc/js/core/Favicon.js' => '7930776a',
456
-
'rsrc/js/core/FileUpload.js' => 'ab85e184',
456
+
'rsrc/js/core/FileUpload.js' => '331676ea',
457
457
'rsrc/js/core/Hovercard.js' => '6199f752',
458
458
'rsrc/js/core/HovercardList.js' => 'de4b4919',
459
459
'rsrc/js/core/KeyboardShortcut.js' => '1a844c06',
···
731
731
'javelin-sound' => 'd4cc2d2a',
732
732
'javelin-stratcom' => '0889b835',
733
733
'javelin-tokenizer' => '89a1ae3a',
734
-
'javelin-typeahead' => 'd96e47a4',
734
+
'javelin-typeahead' => '0507519c',
735
735
'javelin-typeahead-composite-source' => '22ee68a5',
736
736
'javelin-typeahead-normalizer' => 'a241536a',
737
737
'javelin-typeahead-ondemand-source' => '23387297',
···
751
751
'javelin-workboard-card' => '0392a5d8',
752
752
'javelin-workboard-card-template' => '84f82dad',
753
753
'javelin-workboard-column' => 'c3d24e63',
754
-
'javelin-workboard-controller' => 'b9d0c2f3',
754
+
'javelin-workboard-controller' => '7474d31f',
755
755
'javelin-workboard-drop-effect' => '8e0aa661',
756
756
'javelin-workboard-header' => '111bfd2d',
757
757
'javelin-workboard-header-template' => 'ebe83a6b',
758
758
'javelin-workboard-order-template' => '03e8891f',
759
-
'javelin-workflow' => 'd7ba6915',
759
+
'javelin-workflow' => 'cc1553f3',
760
760
'maniphest-report-css' => '3d53188b',
761
761
'maniphest-task-edit-css' => '272daa84',
762
762
'maniphest-task-summary-css' => '61d1667e',
···
787
787
'phabricator-fatal-config-template-css' => 'e689dbbd',
788
788
'phabricator-favicon' => '7930776a',
789
789
'phabricator-feed-css' => 'd8b6e3f8',
790
-
'phabricator-file-upload' => 'ab85e184',
790
+
'phabricator-file-upload' => '331676ea',
791
791
'phabricator-flag-css' => '2b77be8d',
792
792
'phabricator-keyboard-shortcut' => '1a844c06',
793
793
'phabricator-keyboard-shortcut-manager' => '81debc48',
···
965
965
'javelin-dom',
966
966
'javelin-workflow',
967
967
),
968
+
'0507519c' => array(
969
+
'javelin-install',
970
+
'javelin-dom',
971
+
'javelin-vector',
972
+
'javelin-util',
973
+
),
968
974
'05d290ef' => array(
969
975
'javelin-install',
970
976
'javelin-util',
···
1206
1212
'javelin-behavior',
1207
1213
'javelin-stratcom',
1208
1214
'javelin-dom',
1215
+
),
1216
+
'331676ea' => array(
1217
+
'javelin-install',
1218
+
'javelin-dom',
1219
+
'phabricator-notification',
1209
1220
),
1210
1221
34450586 => array(
1211
1222
'javelin-color',
···
1589
1600
'javelin-behavior',
1590
1601
'javelin-dom',
1591
1602
),
1603
+
'7474d31f' => array(
1604
+
'javelin-install',
1605
+
'javelin-dom',
1606
+
'javelin-util',
1607
+
'javelin-vector',
1608
+
'javelin-stratcom',
1609
+
'javelin-workflow',
1610
+
'phabricator-drag-and-drop-file-upload',
1611
+
'javelin-workboard-board',
1612
+
),
1592
1613
'78bc5d94' => array(
1593
1614
'javelin-behavior',
1594
1615
'javelin-uri',
···
1856
1877
'javelin-json',
1857
1878
'phuix-form-control-view',
1858
1879
),
1859
-
'ab85e184' => array(
1860
-
'javelin-install',
1861
-
'javelin-dom',
1862
-
'phabricator-notification',
1863
-
),
1864
1880
'ac10c917' => array(
1865
1881
'javelin-behavior',
1866
1882
'javelin-dom',
···
1983
1999
'javelin-uri',
1984
2000
'phabricator-notification',
1985
2001
),
1986
-
'b9d0c2f3' => array(
1987
-
'javelin-install',
1988
-
'javelin-dom',
1989
-
'javelin-util',
1990
-
'javelin-vector',
1991
-
'javelin-stratcom',
1992
-
'javelin-workflow',
1993
-
'phabricator-drag-and-drop-file-upload',
1994
-
'javelin-workboard-board',
1995
-
),
1996
2002
'bf159129' => array(
1997
2003
'phui-inline-comment-view-css',
1998
2004
),
···
2034
2040
'javelin-workflow',
2035
2041
'javelin-json',
2036
2042
),
2043
+
'cc1553f3' => array(
2044
+
'javelin-stratcom',
2045
+
'javelin-request',
2046
+
'javelin-dom',
2047
+
'javelin-vector',
2048
+
'javelin-install',
2049
+
'javelin-util',
2050
+
'javelin-mask',
2051
+
'javelin-uri',
2052
+
'javelin-routable',
2053
+
),
2037
2054
'cc2c5de5' => array(
2038
2055
'javelin-install',
2039
2056
'phuix-button-view',
···
2063
2080
'd4cc2d2a' => array(
2064
2081
'javelin-install',
2065
2082
),
2066
-
'd7ba6915' => array(
2067
-
'javelin-stratcom',
2068
-
'javelin-request',
2069
-
'javelin-dom',
2070
-
'javelin-vector',
2071
-
'javelin-install',
2072
-
'javelin-util',
2073
-
'javelin-mask',
2074
-
'javelin-uri',
2075
-
'javelin-routable',
2076
-
),
2077
2083
'd7d3ba75' => array(
2078
2084
'javelin-dom',
2079
2085
'javelin-util',
···
2093
2099
'javelin-dom',
2094
2100
'javelin-util',
2095
2101
'phabricator-shaped-request',
2096
-
),
2097
-
'd96e47a4' => array(
2098
-
'javelin-install',
2099
-
'javelin-dom',
2100
-
'javelin-vector',
2101
-
'javelin-util',
2102
2102
),
2103
2103
'da15d3dc' => array(
2104
2104
'phui-oi-list-view-css',
+3
-3
src/applications/system/controller/PhabricatorSystemReadOnlyController.php
+3
-3
src/applications/system/controller/PhabricatorSystemReadOnlyController.php
···
16
16
case PhabricatorEnv::READONLY_CONFIG:
17
17
$title = pht('Administrative Read-Only Mode');
18
18
$body[] = pht(
19
-
'An administrator has placed this server into read-only mode.');
19
+
'An Administrator has placed this server into read-only mode.');
20
20
$body[] = pht(
21
21
'This mode may be used to perform temporary maintenance, test '.
22
22
'configuration, or archive an installation permanently.');
···
26
26
'has been turned on by rolling your chair away from your desk and '.
27
27
'yelling "Hey! Why is %s in read-only mode??!" using '.
28
28
'your very loudest outside voice.',
29
-
PlatformSymbols::getPlatformServerSymbol());
29
+
PlatformSymbols::getPlatformServerName());
30
30
$body[] = pht(
31
31
'This mode is active because it is enabled in the configuration '.
32
32
'option "%s".',
···
110
110
111
111
if ($viewer->getIsAdmin()) {
112
112
$body[] = pht(
113
-
'As an administrator, you can review status information from the '.
113
+
'As an Administrator, you can review status information from the '.
114
114
'%s control panel. This may provide more information about the '.
115
115
'current state of affairs.',
116
116
phutil_tag(