Update pinboard view styles, move to PHUI · recaptime.dev/phorge@9c999e3

+54 -54

src/__celerity_resource_map__.php

··· 863 863 ), 864 864 'aphront-list-filter-view-css' => 865 865 array( 866 - 'uri' => '/res/d7b529ce/rsrc/css/aphront/list-filter-view.css', 866 + 'uri' => '/res/a90a0c94/rsrc/css/aphront/list-filter-view.css', 867 867 'type' => 'css', 868 868 'requires' => 869 869 array( ··· 3345 3345 ), 3346 3346 'disk' => '/rsrc/js/core/phtize.js', 3347 3347 ), 3348 - 'phabricator-pinboard-view-css' => 3349 - array( 3350 - 'uri' => '/res/61ecd7cf/rsrc/css/layout/phabricator-pinboard-view.css', 3351 - 'type' => 'css', 3352 - 'requires' => 3353 - array( 3354 - ), 3355 - 'disk' => '/rsrc/css/layout/phabricator-pinboard-view.css', 3356 - ), 3357 3348 'phabricator-prefab' => 3358 3349 array( 3359 3350 'uri' => '/res/511859ca/rsrc/js/core/Prefab.js', ··· 3825 3816 ), 3826 3817 'disk' => '/rsrc/css/phui/phui-list.css', 3827 3818 ), 3819 + 'phui-pinboard-view-css' => 3820 + array( 3821 + 'uri' => '/res/3b961aa1/rsrc/css/phui/phui-pinboard-view.css', 3822 + 'type' => 'css', 3823 + 'requires' => 3824 + array( 3825 + ), 3826 + 'disk' => '/rsrc/css/phui/phui-pinboard-view.css', 3827 + ), 3828 3828 'phui-remarkup-preview-css' => 3829 3829 array( 3830 3830 'uri' => '/res/4535e062/rsrc/css/phui/phui-remarkup-preview.css', ··· 4161 4161 ), array( 4162 4162 'packages' => 4163 4163 array( 4164 - '604768b8' => 4164 + '00dd9b38' => 4165 4165 array( 4166 4166 'name' => 'core.pkg.css', 4167 4167 'symbols' => ··· 4209 4209 40 => 'phabricator-property-list-view-css', 4210 4210 41 => 'phabricator-tag-view-css', 4211 4211 ), 4212 - 'uri' => '/res/pkg/604768b8/core.pkg.css', 4212 + 'uri' => '/res/pkg/00dd9b38/core.pkg.css', 4213 4213 'type' => 'css', 4214 4214 ), 4215 4215 '606f7152' => ··· 4400 4400 ), 4401 4401 'reverse' => 4402 4402 array( 4403 - 'aphront-dialog-view-css' => '604768b8', 4404 - 'aphront-error-view-css' => '604768b8', 4405 - 'aphront-form-view-css' => '604768b8', 4406 - 'aphront-list-filter-view-css' => '604768b8', 4407 - 'aphront-pager-view-css' => '604768b8', 4408 - 'aphront-panel-view-css' => '604768b8', 4409 - 'aphront-table-view-css' => '604768b8', 4410 - 'aphront-tokenizer-control-css' => '604768b8', 4411 - 'aphront-tooltip-css' => '604768b8', 4412 - 'aphront-typeahead-control-css' => '604768b8', 4403 + 'aphront-dialog-view-css' => '00dd9b38', 4404 + 'aphront-error-view-css' => '00dd9b38', 4405 + 'aphront-form-view-css' => '00dd9b38', 4406 + 'aphront-list-filter-view-css' => '00dd9b38', 4407 + 'aphront-pager-view-css' => '00dd9b38', 4408 + 'aphront-panel-view-css' => '00dd9b38', 4409 + 'aphront-table-view-css' => '00dd9b38', 4410 + 'aphront-tokenizer-control-css' => '00dd9b38', 4411 + 'aphront-tooltip-css' => '00dd9b38', 4412 + 'aphront-typeahead-control-css' => '00dd9b38', 4413 4413 'differential-changeset-view-css' => 'dd27a69b', 4414 4414 'differential-core-view-css' => 'dd27a69b', 4415 4415 'differential-inline-comment-editor' => '48040be9', ··· 4423 4423 'differential-table-of-contents-css' => 'dd27a69b', 4424 4424 'diffusion-commit-view-css' => 'c8ce2d88', 4425 4425 'diffusion-icons-css' => 'c8ce2d88', 4426 - 'global-drag-and-drop-css' => '604768b8', 4426 + 'global-drag-and-drop-css' => '00dd9b38', 4427 4427 'inline-comment-summary-css' => 'dd27a69b', 4428 4428 'javelin-aphlict' => '606f7152', 4429 4429 'javelin-behavior' => '2dbbb7d1', ··· 4496 4496 'javelin-util' => '2dbbb7d1', 4497 4497 'javelin-vector' => '2dbbb7d1', 4498 4498 'javelin-workflow' => '2dbbb7d1', 4499 - 'lightbox-attachment-css' => '604768b8', 4499 + 'lightbox-attachment-css' => '00dd9b38', 4500 4500 'maniphest-task-summary-css' => '06bacb9a', 4501 4501 'maniphest-transaction-detail-css' => '06bacb9a', 4502 - 'phabricator-action-list-view-css' => '604768b8', 4503 - 'phabricator-application-launch-view-css' => '604768b8', 4502 + 'phabricator-action-list-view-css' => '00dd9b38', 4503 + 'phabricator-application-launch-view-css' => '00dd9b38', 4504 4504 'phabricator-busy' => '606f7152', 4505 4505 'phabricator-content-source-view-css' => 'dd27a69b', 4506 - 'phabricator-core-css' => '604768b8', 4507 - 'phabricator-crumbs-view-css' => '604768b8', 4506 + 'phabricator-core-css' => '00dd9b38', 4507 + 'phabricator-crumbs-view-css' => '00dd9b38', 4508 4508 'phabricator-drag-and-drop-file-upload' => '48040be9', 4509 4509 'phabricator-dropdown-menu' => '606f7152', 4510 4510 'phabricator-file-upload' => '606f7152', 4511 - 'phabricator-filetree-view-css' => '604768b8', 4512 - 'phabricator-flag-css' => '604768b8', 4513 - 'phabricator-form-view-css' => '604768b8', 4514 - 'phabricator-header-view-css' => '604768b8', 4511 + 'phabricator-filetree-view-css' => '00dd9b38', 4512 + 'phabricator-flag-css' => '00dd9b38', 4513 + 'phabricator-form-view-css' => '00dd9b38', 4514 + 'phabricator-header-view-css' => '00dd9b38', 4515 4515 'phabricator-hovercard' => '606f7152', 4516 - 'phabricator-jump-nav' => '604768b8', 4516 + 'phabricator-jump-nav' => '00dd9b38', 4517 4517 'phabricator-keyboard-shortcut' => '606f7152', 4518 4518 'phabricator-keyboard-shortcut-manager' => '606f7152', 4519 - 'phabricator-main-menu-view' => '604768b8', 4519 + 'phabricator-main-menu-view' => '00dd9b38', 4520 4520 'phabricator-menu-item' => '606f7152', 4521 - 'phabricator-nav-view-css' => '604768b8', 4521 + 'phabricator-nav-view-css' => '00dd9b38', 4522 4522 'phabricator-notification' => '606f7152', 4523 - 'phabricator-notification-css' => '604768b8', 4524 - 'phabricator-notification-menu-css' => '604768b8', 4525 - 'phabricator-object-item-list-view-css' => '604768b8', 4523 + 'phabricator-notification-css' => '00dd9b38', 4524 + 'phabricator-notification-menu-css' => '00dd9b38', 4525 + 'phabricator-object-item-list-view-css' => '00dd9b38', 4526 4526 'phabricator-object-selector-css' => 'dd27a69b', 4527 4527 'phabricator-phtize' => '606f7152', 4528 4528 'phabricator-prefab' => '606f7152', 4529 4529 'phabricator-project-tag-css' => '06bacb9a', 4530 - 'phabricator-property-list-view-css' => '604768b8', 4531 - 'phabricator-remarkup-css' => '604768b8', 4530 + 'phabricator-property-list-view-css' => '00dd9b38', 4531 + 'phabricator-remarkup-css' => '00dd9b38', 4532 4532 'phabricator-shaped-request' => '48040be9', 4533 - 'phabricator-side-menu-view-css' => '604768b8', 4534 - 'phabricator-standard-page-view' => '604768b8', 4535 - 'phabricator-tag-view-css' => '604768b8', 4533 + 'phabricator-side-menu-view-css' => '00dd9b38', 4534 + 'phabricator-standard-page-view' => '00dd9b38', 4535 + 'phabricator-tag-view-css' => '00dd9b38', 4536 4536 'phabricator-textareautils' => '606f7152', 4537 4537 'phabricator-tooltip' => '606f7152', 4538 - 'phabricator-transaction-view-css' => '604768b8', 4539 - 'phabricator-zindex-css' => '604768b8', 4540 - 'phui-button-css' => '604768b8', 4541 - 'phui-form-css' => '604768b8', 4542 - 'phui-icon-view-css' => '604768b8', 4543 - 'phui-spacing-css' => '604768b8', 4544 - 'sprite-apps-large-css' => '604768b8', 4545 - 'sprite-gradient-css' => '604768b8', 4546 - 'sprite-icons-css' => '604768b8', 4547 - 'sprite-menu-css' => '604768b8', 4548 - 'syntax-highlighting-css' => '604768b8', 4538 + 'phabricator-transaction-view-css' => '00dd9b38', 4539 + 'phabricator-zindex-css' => '00dd9b38', 4540 + 'phui-button-css' => '00dd9b38', 4541 + 'phui-form-css' => '00dd9b38', 4542 + 'phui-icon-view-css' => '00dd9b38', 4543 + 'phui-spacing-css' => '00dd9b38', 4544 + 'sprite-apps-large-css' => '00dd9b38', 4545 + 'sprite-gradient-css' => '00dd9b38', 4546 + 'sprite-icons-css' => '00dd9b38', 4547 + 'sprite-menu-css' => '00dd9b38', 4548 + 'syntax-highlighting-css' => '00dd9b38', 4549 4549 ), 4550 4550 ));

+4 -4

src/__phutil_library_map__.php

··· 748 748 'PHUIListView' => 'view/phui/PHUIListView.php', 749 749 'PHUIListViewTestCase' => 'view/layout/__tests__/PHUIListViewTestCase.php', 750 750 'PHUIPagedFormView' => 'view/form/PHUIPagedFormView.php', 751 + 'PHUIPinboardItemView' => 'view/phui/PHUIPinboardItemView.php', 752 + 'PHUIPinboardView' => 'view/phui/PHUIPinboardView.php', 751 753 'PHUIRemarkupPreviewPanel' => 'view/phui/PHUIRemarkupPreviewPanel.php', 752 754 'PHUIStatusItemView' => 'view/phui/PHUIStatusItemView.php', 753 755 'PHUIStatusListView' => 'view/phui/PHUIStatusListView.php', ··· 1408 1410 'PhabricatorPhortuneConfigOptions' => 'applications/phortune/option/PhabricatorPhortuneConfigOptions.php', 1409 1411 'PhabricatorPhrequentConfigOptions' => 'applications/phrequent/config/PhabricatorPhrequentConfigOptions.php', 1410 1412 'PhabricatorPhrictionConfigOptions' => 'applications/phriction/config/PhabricatorPhrictionConfigOptions.php', 1411 - 'PhabricatorPinboardItemView' => 'view/layout/PhabricatorPinboardItemView.php', 1412 - 'PhabricatorPinboardView' => 'view/layout/PhabricatorPinboardView.php', 1413 1413 'PhabricatorPolicies' => 'applications/policy/constants/PhabricatorPolicies.php', 1414 1414 'PhabricatorPolicy' => 'applications/policy/filter/PhabricatorPolicy.php', 1415 1415 'PhabricatorPolicyAwareQuery' => 'infrastructure/query/policy/PhabricatorPolicyAwareQuery.php', ··· 2764 2764 'PHUIListView' => 'AphrontTagView', 2765 2765 'PHUIListViewTestCase' => 'PhabricatorTestCase', 2766 2766 'PHUIPagedFormView' => 'AphrontTagView', 2767 + 'PHUIPinboardItemView' => 'AphrontView', 2768 + 'PHUIPinboardView' => 'AphrontView', 2767 2769 'PHUIRemarkupPreviewPanel' => 'AphrontTagView', 2768 2770 'PHUIStatusItemView' => 'AphrontTagView', 2769 2771 'PHUIStatusListView' => 'AphrontTagView', ··· 3471 3473 'PhabricatorPhortuneConfigOptions' => 'PhabricatorApplicationConfigOptions', 3472 3474 'PhabricatorPhrequentConfigOptions' => 'PhabricatorApplicationConfigOptions', 3473 3475 'PhabricatorPhrictionConfigOptions' => 'PhabricatorApplicationConfigOptions', 3474 - 'PhabricatorPinboardItemView' => 'AphrontView', 3475 - 'PhabricatorPinboardView' => 'AphrontView', 3476 3476 'PhabricatorPolicies' => 'PhabricatorPolicyConstants', 3477 3477 'PhabricatorPolicyAwareQuery' => 'PhabricatorOffsetPagedQuery', 3478 3478 'PhabricatorPolicyAwareTestQuery' => 'PhabricatorPolicyAwareQuery',

+2 -2

src/applications/macro/controller/PhabricatorMacroListController.php

··· 36 36 $this->getLoadedHandles(), 37 37 $author_phids); 38 38 39 - $pinboard = new PhabricatorPinboardView(); 39 + $pinboard = new PHUIPinboardView(); 40 40 foreach ($macros as $macro) { 41 41 $file = $macro->getFile(); 42 42 43 - $item = new PhabricatorPinboardItemView(); 43 + $item = new PHUIPinboardItemView(); 44 44 if ($file) { 45 45 $item->setImageURI($file->getThumb280x210URI()); 46 46 $item->setImageSize(280, 210);

+2 -2

src/applications/pholio/controller/PholioMockListController.php

··· 37 37 } 38 38 $this->loadHandles($author_phids); 39 39 40 - $board = new PhabricatorPinboardView(); 40 + $board = new PHUIPinboardView(); 41 41 foreach ($mocks as $mock) { 42 - $item = id(new PhabricatorPinboardItemView()) 42 + $item = id(new PHUIPinboardItemView()) 43 43 ->setHeader('M'.$mock->getID().' '.$mock->getName()) 44 44 ->setURI('/M'.$mock->getID()) 45 45 ->setImageURI($mock->getCoverFile()->getThumb280x210URI())

+8 -8

src/view/layout/PhabricatorPinboardItemView.php src/view/phui/PHUIPinboardItemView.php

··· 1 1 <?php 2 2 3 - final class PhabricatorPinboardItemView extends AphrontView { 3 + final class PHUIPinboardItemView extends AphrontView { 4 4 5 5 private $imageURI; 6 6 private $uri; ··· 42 42 $header = phutil_tag( 43 43 'div', 44 44 array( 45 - 'class' => 'phabricator-pinboard-item-header', 45 + 'class' => 'phui-pinboard-item-header', 46 46 ), 47 47 phutil_tag('a', array('href' => $this->uri), $this->header)); 48 48 } ··· 51 51 'a', 52 52 array( 53 53 'href' => $this->uri, 54 - 'class' => 'phabricator-pinboard-item-image-link', 54 + 'class' => 'phui-pinboard-item-image-link', 55 55 ), 56 56 phutil_tag( 57 57 'img', ··· 69 69 'span', 70 70 array( 71 71 'class' => 72 - 'phabricator-pinboard-icon sprite-icons icons-'.$block[0].'-grey', 72 + 'phui-pinboard-icon sprite-icons icons-'.$block[0].'-grey', 73 73 ), 74 74 ''); 75 75 $count = phutil_tag('span', array(), $block[1]); 76 76 $icon_list[] = phutil_tag( 77 77 'span', 78 78 array( 79 - 'class' => 'phabricator-pinboard-item-count', 79 + 'class' => 'phui-pinboard-item-count', 80 80 ), 81 81 array($icon, $count)); 82 82 } 83 83 $icons = phutil_tag( 84 84 'div', 85 85 array( 86 - 'class' => 'phabricator-pinboard-icons', 86 + 'class' => 'phui-pinboard-icons', 87 87 ), 88 88 $icon_list); 89 89 } ··· 93 93 $content = phutil_tag( 94 94 'div', 95 95 array( 96 - 'class' => 'phabricator-pinboard-item-content', 96 + 'class' => 'phui-pinboard-item-content', 97 97 ), 98 98 $content); 99 99 } ··· 101 101 return phutil_tag( 102 102 'div', 103 103 array( 104 - 'class' => 'phabricator-pinboard-item-view', 104 + 'class' => 'phui-pinboard-item-view', 105 105 ), 106 106 array( 107 107 $header,

+4 -4

src/view/layout/PhabricatorPinboardView.php src/view/phui/PHUIPinboardView.php

··· 1 1 <?php 2 2 3 - final class PhabricatorPinboardView extends AphrontView { 3 + final class PHUIPinboardView extends AphrontView { 4 4 5 5 private $items = array(); 6 6 private $noDataString; ··· 10 10 return $this; 11 11 } 12 12 13 - public function addItem(PhabricatorPinboardItemView $item) { 13 + public function addItem(PHUIPinboardItemView $item) { 14 14 $this->items[] = $item; 15 15 return $this; 16 16 } 17 17 18 18 public function render() { 19 - require_celerity_resource('phabricator-pinboard-view-css'); 19 + require_celerity_resource('phui-pinboard-view-css'); 20 20 21 21 if (!$this->items) { 22 22 $string = nonempty($this->noDataString, pht('No data.')); ··· 29 29 return phutil_tag( 30 30 'div', 31 31 array( 32 - 'class' => 'phabricator-pinboard-view', 32 + 'class' => 'phui-pinboard-view', 33 33 ), 34 34 $this->items); 35 35 }

+5 -6

webroot/rsrc/css/aphront/list-filter-view.css

··· 16 16 box-shadow: 0 1px 2px rgba(0,0,0,0.2); 17 17 } 18 18 19 - .device-phone .aphront-list-filter-view { 20 - margin: 0; 19 + .device-phone .aphront-list-filter-wrap { 20 + margin: 0 -2px; 21 21 } 22 22 23 23 .aphront-list-filter-view-content .aphront-form-view { ··· 58 58 .device .aphront-list-filter-reveal { 59 59 width: 98%; 60 60 margin: auto; 61 - padding: 4px 0; 61 + padding: 8px; 62 62 } 63 63 64 64 .aphront-list-filter-reveal a { ··· 67 67 } 68 68 69 69 .device .aphront-list-filter-reveal a { 70 - margin: 4px auto 0; 71 - float: none; 72 - display: block; 70 + margin: 4px 0; 71 + float: left; 73 72 } 74 73 75 74 .aphront-list-filter-description {

+18 -18

webroot/rsrc/css/layout/phabricator-pinboard-view.css webroot/rsrc/css/phui/phui-pinboard-view.css

··· 1 1 /** 2 - * @provides phabricator-pinboard-view-css 2 + * @provides phui-pinboard-view-css 3 3 */ 4 4 5 - .phabricator-pinboard-view { 6 - padding: 10px 0 20px 20px; 5 + .phui-pinboard-view { 6 + padding: 8px 0 20px 20px; 7 7 overflow: hidden; 8 - margin: 1em 0; 8 + margin: 12px 0; 9 9 } 10 10 11 - .device-phone .phabricator-pinboard-view { 11 + .device-phone .phui-pinboard-view { 12 12 padding: 0; 13 13 } 14 14 15 - .phabricator-pinboard-item-view { 16 - margin: 0 16px 16px 0; 15 + .phui-pinboard-item-view { 16 + margin: 0 8px 16px 0; 17 17 border: 1px solid #d5d9df; 18 18 background: #ffffff; 19 19 border-radius: 3px; 20 20 21 21 float: left; 22 - width: 300px; 22 + width: 288px; 23 23 box-shadow: 0 1px 3px rgba(0, 0, 0, 0.15); 24 24 text-align: left; 25 25 } 26 26 27 - .device-desktop .phabricator-pinboard-item-view:hover { 27 + .device-desktop .phui-pinboard-item-view:hover { 28 28 cursor: pointer; 29 29 box-shadow: 0 1px 6px rgba(0, 0, 0, 0.30); 30 30 } 31 31 32 32 /* On phones, show a single column of items. */ 33 - .device-phone .phabricator-pinboard-item-view { 33 + .device-phone .phui-pinboard-item-view { 34 34 float: none; 35 35 margin: 0 auto 16px; 36 36 } 37 37 38 - .phabricator-pinboard-item-header { 38 + .phui-pinboard-item-header { 39 39 padding: 5px 10px; 40 40 display: block; 41 41 background: #edf0f4; ··· 47 47 overflow: hidden; 48 48 } 49 49 50 - .phabricator-pinboard-item-header a { 50 + .phui-pinboard-item-header a { 51 51 color: #333; 52 52 } 53 53 54 - .phabricator-pinboard-item-image-link { 55 - padding: 10px; 54 + .phui-pinboard-item-image-link { 55 + padding: 8px 4px; 56 56 display: block; 57 57 } 58 58 59 - .phabricator-pinboard-item-content { 59 + .phui-pinboard-item-content { 60 60 padding: 0 10px 5px; 61 61 overflow: hidden; 62 62 color: #777; 63 63 font-size: 11px; 64 64 } 65 65 66 - .phabricator-pinboard-item-count { 66 + .phui-pinboard-item-count { 67 67 float: left; 68 68 margin-left: 10px; 69 69 } 70 70 71 - .phabricator-pinboard-icons { 71 + .phui-pinboard-icons { 72 72 padding: 0 10px 10px 0; 73 73 color: #aaa; 74 74 border-bottom: 1px solid #e7e7e7; ··· 76 76 overflow: hidden; 77 77 } 78 78 79 - .phabricator-pinboard-icon { 79 + .phui-pinboard-icon { 80 80 height: 14px; 81 81 width: 14px; 82 82 float: left;

Configure Feed

Configure Feed