+2 -2

src/applications/base/PhabricatorApplication.php

reviewed

··· 477 477 * To check if an application is installed at all, use 478 478 * @{method:isClassInstalled}. 479 479 * 480 480 - * @param string Application class name. 481 481 - * @param PhabricatorUser|null Viewing user. 480 480 + * @param string $class Application class name. 481 481 + * @param PhabricatorUser|null $viewer Viewing user. 482 482 * @return bool True if the class is installed or if the installed class is 483 483 * available to the viewer when a viewer is given. 484 484 * @task meta

+3

src/applications/base/controller/PhabricatorController.php

reviewed

··· 454 454 ->setViewer($this->getViewer()); 455 455 } 456 456 457 457 + /** 458 458 + * @return PHUICurtainView 459 459 + */ 457 460 public function newCurtainView($object = null) { 458 461 $viewer = $this->getViewer(); 459 462

+3

src/applications/config/option/PhabricatorApplicationConfigOptions.php

reviewed

··· 5 5 abstract public function getName(); 6 6 abstract public function getDescription(); 7 7 abstract public function getGroup(); 8 8 + /** 9 9 + * @return array<PhabricatorConfigOption> 10 10 + */ 8 11 abstract public function getOptions(); 9 12 10 13 public function getIcon() {

+6

src/applications/herald/storage/HeraldRule.php

reviewed

··· 353 353 ); 354 354 } 355 355 356 356 + /** 357 357 + * @return string String like 'public', 'users', 'admin', or a User PHID 358 358 + */ 356 359 public function getPolicy($capability) { 357 360 if ($capability == PhabricatorPolicyCapability::CAN_VIEW) { 358 361 return PhabricatorPolicies::getMostOpenPolicy(); ··· 374 377 return false; 375 378 } 376 379 380 380 + /** 381 381 + * @return string|null 382 382 + */ 377 383 public function describeAutomaticCapability($capability) { 378 384 if ($capability == PhabricatorPolicyCapability::CAN_VIEW) { 379 385 return null;

+17

src/applications/policy/interface/PhabricatorPolicyInterface.php

reviewed

··· 2 2 3 3 interface PhabricatorPolicyInterface extends PhabricatorPHIDInterface { 4 4 5 5 + /** 6 6 + * @return array<PhabricatorPolicyCapability> 7 7 + */ 5 8 public function getCapabilities(); 9 9 + 10 10 + /** 11 11 + * @param PhabricatorPolicyCapability $capability 12 12 + * @return string A PhabricatorPolicyConstant 13 13 + */ 6 14 public function getPolicy($capability); 15 15 + 16 16 + /** 17 17 + * Whether an object provides automatic capability grants to a user (e.g. the 18 18 + * owner of an object can always see it even if a capability is set to NOONE) 19 19 + * 20 20 + * @param PhabricatorPolicyCapability $capability 21 21 + * @param PhabricatorUser $viewer 22 22 + * @return bool 23 23 + */ 7 24 public function hasAutomaticCapability($capability, PhabricatorUser $viewer); 8 25 9 26 }

+4

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

reviewed

··· 34 34 return $form; 35 35 } 36 36 37 37 + /** 38 38 + * Attach forms to menu items shown in top bar Favorites dropdown 39 39 + * @param array<PhabricatorProfileMenuItemConfiguration> $items 40 40 + */ 37 41 public function willGetMenuItemViewList(array $items) { 38 42 $viewer = $this->getViewer(); 39 43 $engines = PhabricatorEditEngine::getAllEditEngines();

+6

src/applications/transactions/editengine/PhabricatorEditEngine.php

reviewed

··· 78 78 return true; 79 79 } 80 80 81 81 + /** 82 82 + * Whether this EditEngine creates by default an entry in the Favorites 83 83 + * dropdown in the top bar to use the Default Form for this EditEngine 84 84 + * 85 85 + * @return bool 86 86 + */ 81 87 public function isDefaultQuickCreateEngine() { 82 88 return false; 83 89 }

+1 -2

src/infrastructure/daemon/workers/clock/PhabricatorDailyRoutineTriggerClock.php

reviewed

··· 47 47 $next = new DateTime("{$ymd} {$hms} UTC"); 48 48 49 49 // Add a day. 50 50 - // NOTE: DateInterval doesn't exist until PHP 5.3.0, and we currently 51 51 - // target PHP 5.2.3. 50 50 + // TODO: Use PHP's DateInterval instead which exists since PHP 5.3.0 52 51 $next->modify('+1 day'); 53 52 54 53 return (int)$next->format('U');

+1 -1

src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php

reviewed

··· 475 475 * automatically populated as a side effect of objects surviving policy 476 476 * filtering. 477 477 * 478 478 - * @param array<phid, PhabricatorPolicyInterface> $objects Objects to add to 478 478 + * @param array<PhabricatorPolicyInterface> $objects Objects to add to 479 479 * the query workspace. 480 480 * @return $this 481 481 * @task workspace

+7

src/view/form/control/AphrontFormTextAreaControl.php

reviewed

··· 32 32 return $this->placeHolder; 33 33 } 34 34 35 35 + /** 36 36 + * @param string $height One of the AphrontFormTextAreaControl::HEIGHT_* 37 37 + * variables 38 38 + */ 35 39 public function setHeight($height) { 36 40 $this->height = $height; 37 41 return $this; ··· 55 59 return $this; 56 60 } 57 61 62 62 + /** 63 63 + * @return PhutilSafeHTML HTML textarea element 64 64 + */ 58 65 protected function renderInput() { 59 66 60 67 $height_class = null;

+2 -1

src/view/phui/PHUIInfoView.php

reviewed

··· 31 31 } 32 32 33 33 /** 34 34 - * @param string One of the SEVERITY_* constants defined in PHUIInfoView 34 34 + * @param string $severity One of the SEVERITY_* constants defined in 35 35 + * PHUIInfoView 35 36 * @return $this 36 37 */ 37 38 public function setSeverity($severity) {