@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add Column Edit / History actions to workboard columns

Summary: This brings up "Edit Column" as an action item under the main column dropdown as well as a "Column History" for completeness. Unsure column history is actually useful, but leaving it in anyways. It might be nice to have some sort of dialog version of a history page.

Test Plan: Make a workboard, add a column, edit column name, stay on workboard.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D17874

+18 -7
+16
src/applications/project/controller/PhabricatorProjectBoardViewController.php
··· 837 837 ->setHref($batch_edit_uri) 838 838 ->setDisabled(!$can_batch_edit); 839 839 840 + // Column Related Actions Below 841 + // 842 + $edit_uri = 'board/'.$this->id.'/edit/'.$column->getID().'/'; 843 + $column_items[] = id(new PhabricatorActionView()) 844 + ->setName(pht('Edit Column')) 845 + ->setIcon('fa-pencil') 846 + ->setHref($this->getApplicationURI($edit_uri)) 847 + ->setDisabled(!$can_edit) 848 + ->setWorkflow(true); 849 + 840 850 $can_hide = ($can_edit && !$column->isDefaultColumn()); 841 851 $hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/'; 842 852 $hide_uri = $this->getApplicationURI($hide_uri); ··· 857 867 ->setDisabled(!$can_hide) 858 868 ->setWorkflow(true); 859 869 } 870 + 871 + $details_uri = 'board/'.$this->id.'/column/'.$column->getID().'/'; 872 + $column_items[] = id(new PhabricatorActionView()) 873 + ->setName(pht('Column History')) 874 + ->setIcon('fa-columns') 875 + ->setHref($this->getApplicationURI($details_uri)); 860 876 861 877 $column_menu = id(new PhabricatorActionListView()) 862 878 ->setUser($viewer);
+1 -1
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
··· 103 103 ->setIcon('fa-pencil') 104 104 ->setHref($this->getApplicationURI($base_uri.'edit/'.$id.'/')) 105 105 ->setDisabled(!$can_edit) 106 - ->setWorkflow(!$can_edit)); 106 + ->setWorkflow(true)); 107 107 108 108 return $actions; 109 109 }
+1 -6
src/applications/project/controller/PhabricatorProjectColumnEditController.php
··· 51 51 52 52 $validation_exception = null; 53 53 $base_uri = '/board/'.$project_id.'/'; 54 - if ($is_new) { 55 - // we want to go back to the board 56 - $view_uri = $this->getApplicationURI($base_uri); 57 - } else { 58 - $view_uri = $this->getApplicationURI($base_uri.'column/'.$id.'/'); 59 - } 54 + $view_uri = $this->getApplicationURI($base_uri); 60 55 61 56 if ($request->isFormPost()) { 62 57 $v_name = $request->getStr('name');