@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with creating new Repository URIs via the Web UI
Summary I broke this in D16237: that made the CLI workflow work, but we attach the repository earlier in the web workflow and won't have one when we arrive here.
Test Plan: Created a new repository URI from the web UI.
Auditors: chad
+6
-4
+6
-4
src/applications/diffusion/editor/DiffusionURIEditor.php
+6
-4
src/applications/diffusion/editor/DiffusionURIEditor.php
···
78
78
} else {
79
79
$old_uri = null;
80
80
81
-
// When creating a URI, we may not have processed the repository
82
-
// transaction yet. Attach the repository here to make sure we
83
-
// have it for the calls below.
84
-
$object->attachRepository($this->repository);
81
+
// When creating a URI via the API, we may not have processed the
82
+
// repository transaction yet. Attach the repository here to make
83
+
// sure we have it for the calls below.
84
+
if ($this->repository) {
85
+
$object->attachRepository($this->repository);
86
+
}
85
87
}
86
88
87
89
$object->setURI($xaction->getNewValue());