@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
add renderValue() in transactions
Summary: fix T11290.
Test Plan: Paste language type, view in web and in emails (It uses quotes in HTML emails, which I think is something else).
Reviewers: epriestley, chad, #blessed_reviewers
Reviewed By: chad, #blessed_reviewers
Subscribers: Korvin
Maniphest Tasks: T11290
Differential Revision: https://secure.phabricator.com/D16252
+30
-7
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '2fbe65a2',
10
+
'core.pkg.css' => '4e7e9bde',
11
11
'core.pkg.js' => '1bcca0f3',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '3e81ae60',
···
155
155
'rsrc/css/phui/phui-spacing.css' => '042804d6',
156
156
'rsrc/css/phui/phui-status.css' => 'd5263e49',
157
157
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
158
-
'rsrc/css/phui/phui-timeline-view.css' => 'c3782437',
158
+
'rsrc/css/phui/phui-timeline-view.css' => 'bc523970',
159
159
'rsrc/css/phui/phui-two-column-view.css' => '9fb86c85',
160
160
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7',
161
161
'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647',
···
863
863
'phui-status-list-view-css' => 'd5263e49',
864
864
'phui-tag-view-css' => '6bbd83e2',
865
865
'phui-theme-css' => '027ba77e',
866
-
'phui-timeline-view-css' => 'c3782437',
866
+
'phui-timeline-view-css' => 'bc523970',
867
867
'phui-two-column-view-css' => '9fb86c85',
868
868
'phui-workboard-color-css' => 'ac6fe6a7',
869
869
'phui-workboard-view-css' => 'e6d89647',
+8
-4
src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php
+8
-4
src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php
···
15
15
16
16
public function getTitle() {
17
17
return pht(
18
-
"%s updated the paste's language.",
19
-
$this->renderAuthor());
18
+
"%s updated the paste's language from %s to %s.",
19
+
$this->renderAuthor(),
20
+
$this->renderValue($this->getOldValue()),
21
+
$this->renderValue($this->getNewValue()));
20
22
}
21
23
22
24
public function getTitleForFeed() {
23
25
return pht(
24
-
'%s updated the language for %s.',
26
+
'%s updated the language for %s from %s to %s.',
25
27
$this->renderAuthor(),
26
-
$this->renderObject());
28
+
$this->renderObject(),
29
+
$this->renderValue($this->getOldValue()),
30
+
$this->renderValue($this->getNewValue()));
27
31
}
28
32
29
33
}
+14
src/applications/transactions/storage/PhabricatorModularTransactionType.php
+14
src/applications/transactions/storage/PhabricatorModularTransactionType.php
···
141
141
return $display;
142
142
}
143
143
144
+
final protected function renderValue($value) {
145
+
$rendering_target = $this->getStorage()->getRenderingTarget();
146
+
if ($rendering_target == PhabricatorApplicationTransaction::TARGET_TEXT) {
147
+
return sprintf('"%s"', $value);
148
+
}
149
+
150
+
return phutil_tag(
151
+
'span',
152
+
array(
153
+
'class' => 'phui-timeline-value',
154
+
),
155
+
$value);
156
+
}
157
+
144
158
final protected function newError($title, $message, $xaction = null) {
145
159
return new PhabricatorApplicationTransactionValidationError(
146
160
$this->getTransactionTypeConstant(),