@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't issue unnecssary query when loading user profile images
Summary: Fixes T2264.
Test Plan: Loaded profile.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2264
Differential Revision: https://secure.phabricator.com/D4324
+5
-3
+5
-3
src/applications/people/storage/PhabricatorUser.php
+5
-3
src/applications/people/storage/PhabricatorUser.php
···
630
630
public function loadProfileImageURI() {
631
631
$src_phid = $this->getProfileImagePHID();
632
632
633
-
$file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
634
-
if ($file) {
635
-
return $file->getBestURI();
633
+
if ($src_phid) {
634
+
$file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
635
+
if ($file) {
636
+
return $file->getBestURI();
637
+
}
636
638
}
637
639
638
640
return self::getDefaultProfileImageURI();