@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

When printing, wrap all content in Remarkup tables more aggressively

Summary:
Ref T13564. See PHI1798. Earlier efforts here (see D21439) still leave us with:

- Incorrect behavior for long URIs, like `http://www.example.com/MMMMM...`.
- Incorrect beahvior for long text blocks, like `MMMMMM...`.
- Undesirable behavior for monospaced text in non-printing contexts (it wraps when we'd prefer it not wrap).

Apply the wrapping rules to all "<td>" content to resolve these three prongs.

Test Plan:
- Viewed long URIs, text blocks, and monospaced text in and out of tables, while printed and not printed, in Safari, Firefox, and Chrome.
- All browser behavior now appears to be correct ("all content is preserved in printed document").
- Some browser behavior when making wrapping choices is questionable, but I can't find an automatic solution for that.

Maniphest Tasks: T13564

Differential Revision: https://secure.phabricator.com/D21472

+15 -8
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '0e3cf785', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => 'bd937962', 12 + 'core.pkg.css' => '937616c0', 13 13 'core.pkg.js' => 'adc34883', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '5c459f92', ··· 114 114 'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd', 115 115 'rsrc/css/application/uiexample/example.css' => 'b4795059', 116 116 'rsrc/css/core/core.css' => 'b3ebd90d', 117 - 'rsrc/css/core/remarkup.css' => '94c3d777', 117 + 'rsrc/css/core/remarkup.css' => '24d48a73', 118 118 'rsrc/css/core/syntax.css' => '548567f6', 119 119 'rsrc/css/core/z-index.css' => 'ac3bfcd4', 120 120 'rsrc/css/diviner/diviner-shared.css' => '4bd263b0', ··· 806 806 'phabricator-object-selector-css' => 'ee77366f', 807 807 'phabricator-phtize' => '2f1db1ed', 808 808 'phabricator-prefab' => '5793d835', 809 - 'phabricator-remarkup-css' => '94c3d777', 809 + 'phabricator-remarkup-css' => '24d48a73', 810 810 'phabricator-search-results-css' => '9ea70ace', 811 811 'phabricator-shaped-request' => '995f5102', 812 812 'phabricator-slowvote-css' => '1694baed',
+12 -5
webroot/rsrc/css/core/remarkup.css
··· 86 86 padding: 1px 4px; 87 87 border-radius: 3px; 88 88 white-space: pre-wrap; 89 - 90 - /* See T13564. This is a narrow control for PDF printing behavior in 91 - Chrome. */ 92 - line-break: anywhere; 93 - overflow-wrap: anywhere; 94 89 } 95 90 96 91 /* NOTE: You can currently produce this with [[link | `name`]]. Restore the ··· 499 494 overflow-x: auto; 500 495 } 501 496 497 + !print .phabricator-remarkup .remarkup-table-wrap { 498 + overflow-x: hidden; 499 + } 500 + 502 501 .phabricator-remarkup table.remarkup-table { 503 502 border-collapse: separate; 504 503 border-spacing: 1px; ··· 516 515 .phabricator-remarkup table.remarkup-table td { 517 516 background: {$page.content}; 518 517 padding: 3px 6px; 518 + } 519 + 520 + !print .phabricator-remarkup table.remarkup-table td { 521 + /* See T13564. This is a narrow control for PDF printing behavior in 522 + Chrome. */ 523 + 524 + line-break: anywhere; 525 + overflow-wrap: anywhere; 519 526 } 520 527 521 528 body div.phabricator-remarkup.remarkup-has-toc