@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Pass "." to `git grep` to satisfy "all paths" for Git 2.16.0
Summary:
Ref T13050. See <https://discourse.phabricator-community.org/t/issues-with-git-2-16-0/1004/2>.
`secure` picked up 2.16.0 so this reproduces now: <https://secure.phabricator.com/source/phabricator/browse/master/?grep=dog>
Test Plan: Will push.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13050
Differential Revision: https://secure.phabricator.com/D18944
+6
+6
src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php
+6
src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php
···
95
95
$limit = $request->getValue('limit');
96
96
$offset = $request->getValue('offset');
97
97
98
+
// Starting with Git 2.16.0, Git assumes passing an empty argument is
99
+
// an error and recommends you pass "." instead.
100
+
if (!strlen($path)) {
101
+
$path = '.';
102
+
}
103
+
98
104
$results = array();
99
105
$future = $repository->getLocalCommandFuture(
100
106
'grep --rev %s --print0 --line-number -- %s %s',