@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Apply Owners reviewers using ModularTransactions
Summary: Ref T10967. See that task for some discussion. This lets us do double writes on this pathway.
Test Plan: Set an Owners package to auto-review. Created revisions which triggered it: one with no reviewers (autoreview added); one with the package as a blocking reviewer explicitly (no automatic stuff happened, as expected).
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10967
Differential Revision: https://secure.phabricator.com/D17512
+8
-9
+8
-9
src/applications/differential/editor/DifferentialTransactionEditor.php
+8
-9
src/applications/differential/editor/DifferentialTransactionEditor.php
···
1687
1687
1688
1688
$value = array();
1689
1689
foreach ($phids as $phid) {
1690
-
$value[$phid] = array(
1691
-
'data' => array(
1692
-
'status' => $new_status,
1693
-
),
1694
-
);
1690
+
if ($is_blocking) {
1691
+
$value[] = 'blocking('.$phid.')';
1692
+
} else {
1693
+
$value[] = $phid;
1694
+
}
1695
1695
}
1696
-
1697
-
$edgetype_reviewer = DifferentialRevisionHasReviewerEdgeType::EDGECONST;
1698
1696
1699
1697
$owners_phid = id(new PhabricatorOwnersApplication())
1700
1698
->getPHID();
1701
1699
1700
+
$reviewers_type = DifferentialRevisionReviewersTransaction::TRANSACTIONTYPE;
1701
+
1702
1702
return $object->getApplicationTransactionTemplate()
1703
1703
->setAuthorPHID($owners_phid)
1704
-
->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
1705
-
->setMetadataValue('edge:type', $edgetype_reviewer)
1704
+
->setTransactionType($reviewers_type)
1706
1705
->setNewValue(
1707
1706
array(
1708
1707
'+' => $value,