@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't require working copy to generate URIs in owners tool
Summary:
Owners packages might include repositories that are no longer tracked
(or checked out locally), and there's no reason why we need a working copy
to generate a diffusion link. Instead of displaying a red error box, this
diff allows the owners tool to render correctly.
Test Plan:
viewed /owners/view/all/ and /owners/package/395/ and verified no error box
for not having a checkout of the repository.
Reviewers: epriestley, vrana, wez
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3452
+6
-12
+2
-5
src/applications/owners/controller/PhabricatorOwnersDetailController.php
+2
-5
src/applications/owners/controller/PhabricatorOwnersDetailController.php
···
98
98
$path_links = array();
99
99
foreach ($paths as $path) {
100
100
$repo = $repositories[$path->getRepositoryPHID()];
101
-
$drequest = DiffusionRequest::newFromDictionary(
101
+
$href = DiffusionRequest::generateDiffusionURI(
102
102
array(
103
-
'repository' => $repo,
103
+
'callsign' => $repo->getCallsign(),
104
104
'path' => $path->getPath(),
105
-
));
106
-
$href = $drequest->generateURI(
107
-
array(
108
105
'action' => 'browse'
109
106
));
110
107
$repo_name = '<strong>'.phutil_escape_html($repo->getName()).
+4
-7
src/applications/owners/controller/PhabricatorOwnersListController.php
+4
-7
src/applications/owners/controller/PhabricatorOwnersListController.php
···
262
262
foreach ($pkg_paths as $key => $path) {
263
263
$repo = $repositories[$path->getRepositoryPHID()];
264
264
if ($repo) {
265
-
$drequest = DiffusionRequest::newFromDictionary(
265
+
$href = DiffusionRequest::generateDiffusionURI(
266
266
array(
267
-
'repository' => $repo,
268
-
'path' => $path->getPath(),
269
-
));
270
-
$href = $drequest->generateURI(
271
-
array(
272
-
'action' => 'browse',
267
+
'callsign' => $repo->getCallsign(),
268
+
'path' => $path->getPath(),
269
+
'action' => 'browse',
273
270
));
274
271
$pkg_paths[$key] =
275
272
'<strong>'.phutil_escape_html($repo->getName()).'</strong> '.