@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix local time test case for logged-out viewers using global settings
Summary:
In D16936, I changed logged-out viewers so they use global settings.
This can lead to a `SELECT` from an isolated unit test. Instead, give the test fixtures and use standard `generateNewUser()` stuff.
Test Plan: Ran `arc unit --everything`.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D16952
+8
-2
+8
-2
src/view/__tests__/PhabricatorLocalTimeTestCase.php
+8
-2
src/view/__tests__/PhabricatorLocalTimeTestCase.php
···
2
2
3
3
final class PhabricatorLocalTimeTestCase extends PhabricatorTestCase {
4
4
5
+
protected function getPhabricatorTestCaseConfiguration() {
6
+
return array(
7
+
self::PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES => true,
8
+
);
9
+
}
10
+
5
11
public function testLocalTimeFormatting() {
6
-
$user = new PhabricatorUser();
12
+
$user = $this->generateNewTestUser();
7
13
$user->overrideTimezoneIdentifier('America/Los_Angeles');
8
14
9
-
$utc = new PhabricatorUser();
15
+
$utc = $this->generateNewTestUser();
10
16
$utc->overrideTimezoneIdentifier('UTC');
11
17
12
18
$this->assertEqual(