@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with creating tasks directly into milestone columns
Summary:
These columns were conflating `projectPHID` (the defualt project to add to the task) with `boardPHID` (the board the column appears on).
Separate them to fix the beahvior.
Test Plan: Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15242
+15
-14
+12
-12
resources/celerity/map.php
+12
-12
resources/celerity/map.php
···
418
418
'rsrc/js/application/projects/WorkboardBoard.js' => '52291776',
419
419
'rsrc/js/application/projects/WorkboardCard.js' => 'c587b80f',
420
420
'rsrc/js/application/projects/WorkboardColumn.js' => 'f05d6e5d',
421
-
'rsrc/js/application/projects/WorkboardController.js' => 'fa1378c3',
421
+
'rsrc/js/application/projects/WorkboardController.js' => '55baf5ed',
422
422
'rsrc/js/application/projects/behavior-project-boards.js' => '14a1faae',
423
423
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
424
424
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
···
729
729
'javelin-workboard-board' => '52291776',
730
730
'javelin-workboard-card' => 'c587b80f',
731
731
'javelin-workboard-column' => 'f05d6e5d',
732
-
'javelin-workboard-controller' => 'fa1378c3',
732
+
'javelin-workboard-controller' => '55baf5ed',
733
733
'javelin-workflow' => '5b2e3e2b',
734
734
'lightbox-attachment-css' => '7acac05d',
735
735
'maniphest-batch-editor' => 'b0f0b6d5',
···
1252
1252
'javelin-behavior',
1253
1253
'javelin-vector',
1254
1254
'javelin-dom',
1255
+
),
1256
+
'55baf5ed' => array(
1257
+
'javelin-install',
1258
+
'javelin-dom',
1259
+
'javelin-util',
1260
+
'javelin-vector',
1261
+
'javelin-stratcom',
1262
+
'javelin-workflow',
1263
+
'phabricator-drag-and-drop-file-upload',
1264
+
'javelin-workboard-board',
1255
1265
),
1256
1266
'56a1ca03' => array(
1257
1267
'javelin-behavior',
···
2097
2107
'javelin-dom',
2098
2108
'javelin-vector',
2099
2109
'javelin-magical-init',
2100
-
),
2101
-
'fa1378c3' => array(
2102
-
'javelin-install',
2103
-
'javelin-dom',
2104
-
'javelin-util',
2105
-
'javelin-vector',
2106
-
'javelin-stratcom',
2107
-
'javelin-workflow',
2108
-
'phabricator-drag-and-drop-file-upload',
2109
-
'javelin-workboard-board',
2110
2110
),
2111
2111
'fb20ac8d' => array(
2112
2112
'javelin-behavior',
+1
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+1
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+2
-2
webroot/rsrc/js/application/projects/WorkboardController.js
+2
-2
webroot/rsrc/js/application/projects/WorkboardController.js
···
158
158
var column_data = e.getNodeData('column-add-task');
159
159
var column_phid = column_data.columnPHID;
160
160
161
-
var board_phid = column_data.projectPHID;
161
+
var board_phid = column_data.boardPHID;
162
162
var board = this._getBoard(board_phid);
163
163
var column = board.getColumn(column_phid);
164
164
165
165
var request_data = {
166
166
responseType: 'card',
167
167
columnPHID: column.getPHID(),
168
-
projects: board.getPHID(),
168
+
projects: column_data.projectPHID,
169
169
visiblePHIDs: column.getCardPHIDs(),
170
170
order: board.getOrder()
171
171
};