@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up some Phame transaction edit bugs
Summary: Ref T12685. Sets required on required fields, cleans up mailtags on PhamePost
Test Plan: Create a new blog, post.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12685
Differential Revision: https://secure.phabricator.com/D17850
+5
-3
+1
src/applications/phame/editor/PhameBlogEditEngine.php
+1
src/applications/phame/editor/PhameBlogEditEngine.php
···
76
76
->setConduitDescription(pht('Retitle the blog.'))
77
77
->setConduitTypeDescription(pht('New blog title.'))
78
78
->setTransactionType(PhameBlogNameTransaction::TRANSACTIONTYPE)
79
+
->setIsRequired(true)
79
80
->setValue($object->getName()),
80
81
id(new PhabricatorTextEditField())
81
82
->setKey('subtitle')
+1
src/applications/phame/editor/PhamePostEditEngine.php
+1
src/applications/phame/editor/PhamePostEditEngine.php
···
98
98
->setConduitDescription(pht('Retitle the post.'))
99
99
->setConduitTypeDescription(pht('New post title.'))
100
100
->setTransactionType(PhamePostTitleTransaction::TRANSACTIONTYPE)
101
+
->setIsRequired(true)
101
102
->setValue($object->getTitle()),
102
103
id(new PhabricatorTextEditField())
103
104
->setKey('subtitle')
+3
-3
src/applications/phame/storage/PhamePostTransaction.php
+3
-3
src/applications/phame/storage/PhamePostTransaction.php
···
34
34
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
35
35
$tags[] = self::MAILTAG_SUBSCRIBERS;
36
36
break;
37
-
case self::TYPE_TITLE:
38
-
case self::TYPE_SUBTITLE:
39
-
case self::TYPE_BODY:
37
+
case PhamePostTitleTransaction::TRANSACTIONTYPE:
38
+
case PhamePostSubtitleTransaction::TRANSACTIONTYPE:
39
+
case PhamePostBodyTransaction::TRANSACTIONTYPE:
40
40
$tags[] = self::MAILTAG_CONTENT;
41
41
break;
42
42
default: