@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix inadvertent forward dependency in task owner migration
Summary:
See <https://github.com/facebook/phabricator/issues/505>. When the status/event table moved, it broke this migration, which implicitly loads statuses by loading events.
Instead, access just the row we care about.
Test Plan: Used `--apply` to apply the new version of the patch.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D8162
+10
-6
+10
-6
resources/sql/patches/20131118.ownerorder.php
+10
-6
resources/sql/patches/20131118.ownerorder.php
···
3
3
$table = new ManiphestTask();
4
4
$conn_w = $table->establishConnection('w');
5
5
6
+
$user_table = new PhabricatorUser();
7
+
$user_conn = $user_table->establishConnection('r');
8
+
6
9
foreach (new LiskMigrationIterator($table) as $task) {
7
10
$id = $task->getID();
8
11
···
14
17
continue;
15
18
}
16
19
17
-
$owner_handle = id(new PhabricatorHandleQuery())
18
-
->setViewer(PhabricatorUser::getOmnipotentUser())
19
-
->withPHIDs(array($owner_phid))
20
-
->executeOne();
20
+
$owner_row = queryfx_one(
21
+
$user_conn,
22
+
'SELECT * FROM %T WHERE phid = %s',
23
+
$user_table->getTableName(),
24
+
$owner_phid);
21
25
22
-
if ($owner_handle) {
23
-
$value = $owner_handle->getName();
26
+
if ($owner_row) {
27
+
$value = $owner_row['userName'];
24
28
} else {
25
29
$value = null;
26
30
}