@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix two minor issues
Summary:
Ref T7811. Fixes two minor issues I observed in the cluster:
- Sometimes APC doesn't give us key names. Not sure exactly what's up here, but we can do a better job with this.
- The `%` in `25%` actually needs more escaping, since it's interpreted by both `pht()` (immediately) and `console_format()` (later).
Test Plan:
- First one is just from an error log, not sure how to repro offhand.
- Ran `bin/phd help start` for the second one.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T7814, T7811
Differential Revision: https://secure.phabricator.com/D12395
+3
-2
+2
-1
src/applications/cache/spec/PhabricatorDataCacheSpec.php
+2
-1
src/applications/cache/spec/PhabricatorDataCacheSpec.php
···
83
83
$cache = $info['cache_list'];
84
84
$state = array();
85
85
foreach ($cache as $item) {
86
-
$key = self::getKeyPattern($item['info']);
86
+
$info = idx($item, 'info', '<unknown-key>');
87
+
$key = self::getKeyPattern($info);
87
88
if (empty($state[$key])) {
88
89
$state[$key] = array(
89
90
'max' => 0,
+1
-1
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
+1
-1
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
···
619
619
'Specify a proportion of machine memory which must be free '.
620
620
'before autoscale pools will grow. For example, a value of 0.25 '.
621
621
'means that pools will not grow unless the machine has at least '.
622
-
'25%% of its RAM free.'),
622
+
'25%%%% of its RAM free.'),
623
623
);
624
624
}
625
625