recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Switch two listed activities between Install and Quick Start Guides

Summary: Closes T16343

Test Plan:
* Install http://phorge.localhost/applications/view/PhabricatorGuideApplication/
* Go to http://phorge.localhost/guides/quickstart/ and see "Personalize your Install" which makes no sense if not an admin who installed
* Go to http://phorge.localhost/guides/install/ and see "User Account Settings" which has nothing to do with installation
* Apply this patch
* Go to http://phorge.localhost/guides/install/ and now see "Personalize your Install"
* Go to http://phorge.localhost/guides/quickstart/ and now see "User Account Settings"

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16343

Differential Revision: https://we.phorge.it/D26501

Andre Klapper b4ac8907 747cf0fe

+23 -22
+9 -13
src/applications/guides/module/PhabricatorGuideInstallModule.php
··· 107 107 $guide_items->addItem($item); 108 108 109 109 110 - $title = pht('User Account Settings'); 111 - $href = PhabricatorEnv::getURI('/settings/'); 112 - $preferences = id(new PhabricatorUserPreferencesQuery()) 113 - ->setViewer($viewer) 114 - ->withUsers(array($viewer)) 115 - ->executeOne(); 116 - 117 - $have_settings = ($preferences && $preferences->getPreferences()); 118 - if ($have_settings) { 110 + $title = pht('Personalize your Install'); 111 + $wordmark = PhabricatorEnv::getEnvConfig('ui.logo'); 112 + $href = PhabricatorEnv::getURI('/config/edit/ui.logo/'); 113 + if ($wordmark) { 119 114 $icon = 'fa-check'; 120 115 $icon_bg = 'bg-green'; 121 116 $description = pht( 122 - "You've adjusted at least one setting on your account."); 117 + 'It looks amazing, good work. Home Sweet Home.'); 123 118 } else { 124 - $icon = 'fa-wrench'; 119 + $icon = 'fa-home'; 125 120 $icon_bg = 'bg-sky'; 126 - $description = pht( 127 - 'Configure account settings for all users, or just yourself'); 121 + $description = 122 + pht('Change the name and add your company logo, just to give it a '. 123 + 'little extra polish.'); 128 124 } 129 125 130 126 $item = id(new PhabricatorGuideItemView())
+14 -9
src/applications/guides/module/PhabricatorGuideQuickStartModule.php
··· 103 103 ->setDescription($description); 104 104 $guide_items->addItem($item); 105 105 106 - $title = pht('Personalize your Install'); 107 - $wordmark = PhabricatorEnv::getEnvConfig('ui.logo'); 108 - $href = PhabricatorEnv::getURI('/config/edit/ui.logo/'); 109 - if ($wordmark) { 106 + $title = pht('User Account Settings'); 107 + $href = PhabricatorEnv::getURI('/settings/'); 108 + $preferences = id(new PhabricatorUserPreferencesQuery()) 109 + ->setViewer($viewer) 110 + ->withUsers(array($viewer)) 111 + ->executeOne(); 112 + 113 + $have_settings = ($preferences && $preferences->getPreferences()); 114 + if ($have_settings) { 110 115 $icon = 'fa-check'; 111 116 $icon_bg = 'bg-green'; 112 117 $description = pht( 113 - 'It looks amazing, good work. Home Sweet Home.'); 118 + "You've adjusted at least one setting on your account."); 114 119 } else { 115 - $icon = 'fa-home'; 120 + $icon = 'fa-wrench'; 116 121 $icon_bg = 'bg-sky'; 117 - $description = 118 - pht('Change the name and add your company logo, just to give it a '. 119 - 'little extra polish.'); 122 + $description = pht( 123 + 'Configure account settings for all users, or just yourself'); 120 124 } 121 125 122 126 $item = id(new PhabricatorGuideItemView()) ··· 126 130 ->setIconBackground($icon_bg) 127 131 ->setDescription($description); 128 132 $guide_items->addItem($item); 133 + 129 134 130 135 $title = pht('Explore Applications'); 131 136 $href = PhabricatorEnv::getURI('/applications/');