@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Cleaning up day view clusters for events shorter than about 30 minutes
Summary: Cleaning up day view clusters for events shorter than about 30 minutes
Test Plan: Create two event within 30 minutes, 1 minute long, each. Day view should properly cluster the events.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12799
+4
-3
+4
-3
src/view/phui/calendar/PHUICalendarDayView.php
+4
-3
src/view/phui/calendar/PHUICalendarDayView.php
···
84
84
}
85
85
foreach ($current_hour_events as $event) {
86
86
$event_start = $event->getEpochStart();
87
-
$event_end = $event->getEpochEnd();
87
+
$event_end = min($event->getEpochEnd(), $day_end);
88
88
89
89
$top = (($event_start - $hour_start) / ($hour_end - $hour_start))
90
90
* 100;
···
233
233
$this->rangeStart->getEpoch() > $day_end)) {
234
234
$errors[] = pht('Day is out of query range');
235
235
}
236
+
return $errors;
236
237
}
237
238
238
239
private function renderSidebar() {
···
503
504
504
505
foreach ($events as $event) {
505
506
$destination_cluster_key = null;
506
-
$event_start = $event->getEpochStart();
507
-
$event_end = $event->getEpochEnd();
507
+
$event_start = $event->getEpochStart() - (30 * 60);
508
+
$event_end = $event->getEpochEnd() + (30 * 60);
508
509
509
510
foreach ($clusters as $key => $cluster) {
510
511
foreach ($cluster as $clustered_event) {