recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Resurrect setup check for cluster.mailers

Summary:
D19940 removed this file entirely, which has led to at least one user who was unsure how to proceed now that `cluster.mailers` is required for outbound mail: https://discourse.phabricator-community.org/t/invalid-argument-supplied-for-foreach-phabricatormetamtamail-php/2287

This isn't //always// a setup issue for installs that don't care about sending mail, but this at least this gives a sporting chance to users who don't follow the changelogs.

Also, I'm not sure if there's a way to use `pht()` to generate links; right now the phurl is just in plain text.

Test Plan: Removed `cluster.mailers` config; observed expected setup issue.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19964

Austin McKinley b98d46ce 3b94b3e8

+26
+2
src/__phutil_library_map__.php
··· 3411 3411 'PhabricatorMailReceiverTestCase' => 'applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php', 3412 3412 'PhabricatorMailReplyHandler' => 'applications/metamta/replyhandler/PhabricatorMailReplyHandler.php', 3413 3413 'PhabricatorMailRoutingRule' => 'applications/metamta/constants/PhabricatorMailRoutingRule.php', 3414 + 'PhabricatorMailSetupCheck' => 'applications/config/check/PhabricatorMailSetupCheck.php', 3414 3415 'PhabricatorMailStamp' => 'applications/metamta/stamp/PhabricatorMailStamp.php', 3415 3416 'PhabricatorMailTarget' => 'applications/metamta/replyhandler/PhabricatorMailTarget.php', 3416 3417 'PhabricatorMailUtil' => 'applications/metamta/util/PhabricatorMailUtil.php', ··· 9223 9224 'PhabricatorMailReceiverTestCase' => 'PhabricatorTestCase', 9224 9225 'PhabricatorMailReplyHandler' => 'Phobject', 9225 9226 'PhabricatorMailRoutingRule' => 'Phobject', 9227 + 'PhabricatorMailSetupCheck' => 'PhabricatorSetupCheck', 9226 9228 'PhabricatorMailStamp' => 'Phobject', 9227 9229 'PhabricatorMailTarget' => 'Phobject', 9228 9230 'PhabricatorMailUtil' => 'Phobject',
+24
src/applications/config/check/PhabricatorMailSetupCheck.php
··· 1 + <?php 2 + 3 + final class PhabricatorMailSetupCheck extends PhabricatorSetupCheck { 4 + 5 + public function getDefaultGroup() { 6 + return self::GROUP_OTHER; 7 + } 8 + 9 + protected function executeChecks() { 10 + if (PhabricatorEnv::getEnvConfig('cluster.mailers')) { 11 + return; 12 + } 13 + 14 + $message = pht( 15 + 'You haven\'t configured mailers yet, so Phabricator won\'t be able '. 16 + 'to send outbound mail or receive inbound mail. See the '. 17 + 'configuration setting cluster.mailers for details.'); 18 + 19 + $this->newIssue('cluster.mailers') 20 + ->setName(pht('Mailers Not Configured')) 21 + ->setMessage($message) 22 + ->addPhabricatorConfig('cluster.mailers'); 23 + } 24 + }