+3 -1

src/applications/conpherence/editor/ConpherenceEditor.php

reviewed

··· 322 322 return parent::mergeTransactions($u, $v); 323 323 } 324 324 325 325 - protected function supportsMail() { 325 325 + protected function shouldSendMail( 326 326 + PhabricatorLiskDAO $object, 327 327 + array $xactions) { 326 328 return true; 327 329 } 328 330

+3 -1

src/applications/files/editor/PhabricatorFileEditor.php

reviewed

··· 36 36 PhabricatorApplicationTransaction $xaction) { 37 37 } 38 38 39 39 - protected function supportsMail() { 39 39 + protected function shouldSendMail( 40 40 + PhabricatorLiskDAO $object, 41 41 + array $xactions) { 40 42 return true; 41 43 } 42 44

+3 -1

src/applications/legalpad/editor/LegalpadDocumentEditor.php

reviewed

··· 122 122 123 123 /* -( Sending Mail )------------------------------------------------------- */ 124 124 125 125 - protected function supportsMail() { 125 125 + protected function shouldSendMail( 126 126 + PhabricatorLiskDAO $object, 127 127 + array $xactions) { 126 128 return true; 127 129 } 128 130

+11 -1

src/applications/macro/editor/PhabricatorMacroEditor.php

reviewed

··· 78 78 return parent::mergeTransactions($u, $v); 79 79 } 80 80 81 81 - protected function supportsMail() { 81 81 + protected function shouldSendMail( 82 82 + PhabricatorLiskDAO $object, 83 83 + array $xactions) { 84 84 + foreach ($xactions as $xaction) { 85 85 + switch ($xaction->getTransactionType()) { 86 86 + case PhabricatorMacroTransactionType::TYPE_NAME; 87 87 + return ($xaction->getOldValue() !== null); 88 88 + default: 89 89 + break; 90 90 + } 91 91 + } 82 92 return true; 83 93 } 84 94

+11 -1

src/applications/paste/editor/PhabricatorPasteEditor.php

reviewed

··· 100 100 } 101 101 } 102 102 103 103 - protected function supportsMail() { 103 103 + protected function shouldSendMail( 104 104 + PhabricatorLiskDAO $object, 105 105 + array $xactions) { 106 106 + foreach ($xactions as $xaction) { 107 107 + switch ($xaction->getTransactionType()) { 108 108 + case PhabricatorPasteTransaction::TYPE_CREATE: 109 109 + return false; 110 110 + default: 111 111 + break; 112 112 + } 113 113 + } 104 114 return true; 105 115 } 106 116

+3 -1

src/applications/pholio/editor/PholioMockEditor.php

reviewed

··· 288 288 return parent::mergeTransactions($u, $v); 289 289 } 290 290 291 291 - protected function supportsMail() { 291 291 + protected function shouldSendMail( 292 292 + PhabricatorLiskDAO $object, 293 293 + array $xactions) { 292 294 return true; 293 295 } 294 296

+3 -1

src/applications/ponder/editor/PonderQuestionEditor.php

reviewed

··· 165 165 return parent::shouldImplyCC($object, $xaction); 166 166 } 167 167 168 168 - protected function supportsMail() { 168 168 + protected function shouldSendMail( 169 169 + PhabricatorLiskDAO $object, 170 170 + array $xactions) { 169 171 return true; 170 172 } 171 173

+3 -1

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

reviewed

··· 155 155 return parent::filterTransactions($object, $xactions); 156 156 } 157 157 158 158 - protected function supportsMail() { 158 158 + protected function shouldSendMail( 159 159 + PhabricatorLiskDAO $object, 160 160 + array $xactions) { 159 161 return true; 160 162 } 161 163

+4 -2

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

reviewed

··· 457 457 $this->loadHandles($xactions); 458 458 459 459 $mail = null; 460 460 - if ($this->supportsMail()) { 460 460 + if ($this->shouldSendMail($object, $xactions)) { 461 461 $mail = $this->sendMail($object, $xactions); 462 462 } 463 463 ··· 1069 1069 /** 1070 1070 * @task mail 1071 1071 */ 1072 1072 - protected function supportsMail() { 1072 1072 + protected function shouldSendMail( 1073 1073 + PhabricatorLiskDAO $object, 1074 1074 + array $xactions) { 1073 1075 return false; 1074 1076 } 1075 1077