@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update forms to use PHUIFormBoxView
Summary: Some more callsites, let me know if you see others, I think think is 98% of them now.
Test Plan: tested each page
Reviewers: epriestley, btrahan
Reviewed By: btrahan
CC: Korvin, aran
Differential Revision: https://secure.phabricator.com/D6814
+51
-28
+1
-1
src/__celerity_resource_map__.php
+1
-1
src/__celerity_resource_map__.php
···
1140
1140
),
1141
1141
'diffusion-source-css' =>
1142
1142
array(
1143
-
'uri' => '/res/162c8794/rsrc/css/application/diffusion/diffusion-source.css',
1143
+
'uri' => '/res/dcf60c4f/rsrc/css/application/diffusion/diffusion-source.css',
1144
1144
'type' => 'css',
1145
1145
'requires' =>
1146
1146
array(
+6
-2
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
+6
-2
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
···
110
110
->addCancelButton($this->getApplicationURI())
111
111
->setValue('Call Method'));
112
112
113
+
$form_box = id(new PHUIFormBoxView())
114
+
->setHeaderText($method->getAPIMethodName())
115
+
->setFormError($status_view)
116
+
->setForm($form);
117
+
113
118
$crumbs = $this->buildApplicationCrumbs();
114
119
$crumbs->addCrumb(
115
120
id(new PhabricatorCrumbView())
···
118
123
return $this->buildApplicationPage(
119
124
array(
120
125
$crumbs,
121
-
$status_view,
122
-
$form,
126
+
$form_box,
123
127
),
124
128
array(
125
129
'title' => $method->getAPIMethodName(),
+6
-2
src/applications/differential/controller/DifferentialRevisionEditController.php
+6
-2
src/applications/differential/controller/DifferentialRevisionEditController.php
···
184
184
$title = pht('Create New Differential Revision');
185
185
}
186
186
187
+
$form_box = id(new PHUIFormBoxView())
188
+
->setHeaderText($title)
189
+
->setFormError($error_view)
190
+
->setForm($form);
191
+
187
192
$crumbs->addCrumb(
188
193
id(new PhabricatorCrumbView())
189
194
->setName($title));
···
191
196
return $this->buildApplicationPage(
192
197
array(
193
198
$crumbs,
194
-
$error_view,
195
-
$form,
199
+
$form_box,
196
200
$preview),
197
201
array(
198
202
'title' => $title,
+1
src/applications/diffusion/controller/DiffusionCommitController.php
+1
src/applications/diffusion/controller/DiffusionCommitController.php
+4
-4
src/applications/diffusion/controller/DiffusionCommitEditController.php
+4
-4
src/applications/diffusion/controller/DiffusionCommitEditController.php
···
81
81
->addCancelButton('/r'.$callsign.$commit->getCommitIdentifier());
82
82
$form->appendChild($submit);
83
83
84
-
$header = new PhabricatorHeaderView();
85
-
$header->setHeader(pht('Edit Diffusion Commit'));
84
+
$form_box = id(new PHUIFormBoxView())
85
+
->setHeaderText($page_title)
86
+
->setForm($form);
86
87
87
88
return $this->buildApplicationPage(
88
89
array(
89
-
$header,
90
-
$form,
90
+
$form_box,
91
91
),
92
92
array(
93
93
'title' => $page_title,
+15
-6
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
+15
-6
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
···
260
260
->setLabel(pht('Use Picture'))
261
261
->setValue($buttons));
262
262
263
-
$upload_head = id(new PhabricatorHeaderView())
264
-
->setHeader(pht('Upload New Picture'));
263
+
$form_box = id(new PHUIFormBoxView())
264
+
->setHeaderText($title)
265
+
->setFormError($errors)
266
+
->setForm($form);
265
267
266
268
$upload_form = id(new AphrontFormView())
267
269
->setUser($user)
···
282
284
$errors = id(new AphrontErrorView())->setErrors($errors);
283
285
}
284
286
287
+
$form_box = id(new PHUIFormBoxView())
288
+
->setHeaderText($title)
289
+
->setFormError($errors)
290
+
->setForm($form);
291
+
292
+
$upload_box = id(new PHUIFormBoxView())
293
+
->setHeaderText(pht('Upload New Picture'))
294
+
->setForm($upload_form);
295
+
285
296
return $this->buildApplicationPage(
286
297
array(
287
298
$crumbs,
288
-
$errors,
289
-
$form,
290
-
$upload_head,
291
-
$upload_form,
299
+
$form_box,
300
+
$upload_box,
292
301
),
293
302
array(
294
303
'title' => $title,
+5
-5
src/applications/phame/controller/post/PhamePostPublishController.php
+5
-5
src/applications/phame/controller/post/PhamePostPublishController.php
···
37
37
return id(new AphrontRedirectResponse())->setURI($view_uri);
38
38
}
39
39
40
-
$header = id(new PhabricatorHeaderView())
41
-
->setHeader(pht('Preview Post'));
42
-
43
40
$form = id(new AphrontFormView())
44
41
->setUser($user)
45
42
->appendChild(
···
49
46
50
47
$frame = $this->renderPreviewFrame($post);
51
48
49
+
$form_box = id(new PHUIFormBoxView())
50
+
->setHeaderText(pht('Preview Post'))
51
+
->setForm($form);
52
+
52
53
$crumbs = $this->buildApplicationCrumbs();
53
54
$crumbs->addCrumb(
54
55
id(new PhabricatorCrumbView())
···
59
60
$nav->appendChild(
60
61
array(
61
62
$crumbs,
62
-
$header,
63
-
$form,
63
+
$form_box,
64
64
$frame,
65
65
));
66
66
+6
-2
src/applications/releeph/controller/project/ReleephProjectCreateController.php
+6
-2
src/applications/releeph/controller/project/ReleephProjectCreateController.php
···
108
108
->addCancelButton('/releeph/project/')
109
109
->setValue(pht('Create')));
110
110
111
+
$form_box = id(new PHUIFormBoxView())
112
+
->setHeaderText(pht('Create New Project'))
113
+
->setFormError($error_view)
114
+
->setForm($form);
115
+
111
116
$crumbs = $this->buildApplicationCrumbs();
112
117
$crumbs->addCrumb(
113
118
id(new PhabricatorCrumbView())
···
116
121
return $this->buildApplicationPage(
117
122
array(
118
123
$crumbs,
119
-
$error_view,
120
-
$form,
124
+
$form_box,
121
125
),
122
126
array(
123
127
'title' => pht('Create New Project'),
+5
-5
src/applications/repository/controller/PhabricatorRepositoryEditController.php
+5
-5
src/applications/repository/controller/PhabricatorRepositoryEditController.php
···
674
674
id(new AphrontFormSubmitControl())
675
675
->setValue('Save Configuration'));
676
676
677
-
$header = id(new PhabricatorHeaderView())
678
-
->setHeader(pht('Edit Repository Tracking'));
677
+
$form_box = id(new PHUIFormBoxView())
678
+
->setHeaderText(pht('Edit Repository Tracking'))
679
+
->setFormError($error_view)
680
+
->setForm($form);
679
681
680
682
$nav = $this->sideNav;
681
-
$nav->appendChild($error_view);
682
-
$nav->appendChild($header);
683
-
$nav->appendChild($form);
683
+
$nav->appendChild($form_box);
684
684
685
685
return $this->buildApplicationPage(
686
686
$nav,
+1
-1
src/view/form/PHUIFormBoxView.php
+1
-1
src/view/form/PHUIFormBoxView.php