@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add setProfileHeader to PHUIHeaderView for reuse

Summary: Moves some profile css into PHUI, cleans up mobile view and desktop spacing.

Test Plan: Test Project at desktop and mobile breakpoints.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15106

+58 -45
+5 -5
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '8c8210a3', 10 + 'core.pkg.css' => '92f16374', 11 11 'core.pkg.js' => '573e6664', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', ··· 93 93 'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43', 94 94 'rsrc/css/application/policy/policy.css' => '957ea14c', 95 95 'rsrc/css/application/ponder/ponder-view.css' => '7b0df4da', 96 - 'rsrc/css/application/project/project-view.css' => 'efd02445', 96 + 'rsrc/css/application/project/project-view.css' => 'ea27bd1f', 97 97 'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733', 98 98 'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5', 99 99 'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd', ··· 133 133 'rsrc/css/phui/phui-fontkit.css' => '9cda225e', 134 134 'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e', 135 135 'rsrc/css/phui/phui-form.css' => '0b98e572', 136 - 'rsrc/css/phui/phui-header-view.css' => '55bb32dd', 136 + 'rsrc/css/phui/phui-header-view.css' => '235f0d7d', 137 137 'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad', 138 138 'rsrc/css/phui/phui-icon.css' => '3f33ab57', 139 139 'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8', ··· 808 808 'phui-fontkit-css' => '9cda225e', 809 809 'phui-form-css' => '0b98e572', 810 810 'phui-form-view-css' => '4a1a0f5e', 811 - 'phui-header-view-css' => '55bb32dd', 811 + 'phui-header-view-css' => '235f0d7d', 812 812 'phui-icon-set-selector-css' => '1ab67aad', 813 813 'phui-icon-view-css' => '3f33ab57', 814 814 'phui-image-mask-css' => '5a8b09c8', ··· 842 842 'policy-edit-css' => '815c66f7', 843 843 'policy-transaction-detail-css' => '82100a43', 844 844 'ponder-view-css' => '7b0df4da', 845 - 'project-view-css' => 'efd02445', 845 + 'project-view-css' => 'ea27bd1f', 846 846 'raphael-core' => '51ee6b43', 847 847 'raphael-g' => '40dde778', 848 848 'raphael-g-line' => '40da039e',
+2 -8
src/applications/project/controller/PhabricatorProjectProfileController.php
··· 22 22 ->setHeader($project->getName()) 23 23 ->setUser($viewer) 24 24 ->setPolicyObject($project) 25 - ->setImage($picture); 25 + ->setImage($picture) 26 + ->setProfileHeader(true); 26 27 27 28 if ($project->getStatus() == PhabricatorProjectStatus::STATUS_ACTIVE) { 28 29 $header->setStatus('fa-check', 'bluegrey', pht('Active')); ··· 76 77 77 78 $crumbs = $this->buildApplicationCrumbs(); 78 79 $crumbs->setBorder(true); 79 - 80 - $header = phutil_tag( 81 - 'div', 82 - array( 83 - 'class' => 'project-view-header', 84 - ), 85 - $header); 86 80 87 81 require_celerity_resource('project-view-css'); 88 82 $home = phutil_tag(
+10
src/view/phui/PHUIHeaderView.php
··· 12 12 private $headerIcon; 13 13 private $noBackground; 14 14 private $bleedHeader; 15 + private $profileHeader; 15 16 private $tall; 16 17 private $properties = array(); 17 18 private $actionLinks = array(); ··· 63 64 64 65 public function setBleedHeader($bleed) { 65 66 $this->bleedHeader = $bleed; 67 + return $this; 68 + } 69 + 70 + public function setProfileHeader($bighead) { 71 + $this->profileHeader = $bighead; 66 72 return $this; 67 73 } 68 74 ··· 151 157 152 158 if ($this->bleedHeader) { 153 159 $classes[] = 'phui-bleed-header'; 160 + } 161 + 162 + if ($this->profileHeader) { 163 + $classes[] = 'phui-profile-header'; 154 164 } 155 165 156 166 if ($this->properties || $this->policyObject ||
+4 -32
webroot/rsrc/css/application/project/project-view.css
··· 6 6 background: #fff; 7 7 } 8 8 9 - .project-view-header { 10 - padding: 32px 24px 32px; 11 - } 12 - 13 - .project-view-header .phui-header-shell { 14 - margin: 0; 15 - padding: 0; 16 - border: none; 17 - } 18 - 19 - .project-view-header .phui-header-image { 20 - height: 80px; 21 - width: 80px; 22 - } 23 - 24 - .project-view-header .phui-header-col1 { 25 - width: 96px; 26 - } 27 - 28 - .project-view-header .phui-header-subheader { 29 - margin-top: 12px; 30 - } 31 - 32 - .project-view-header .phui-header-shell .phui-header-header { 33 - font-family: 'Aleo', {$fontfamily}; 34 - font-size: 24px; 35 - } 36 - 37 - .project-view-header .phui-header-col3 { 38 - vertical-align: top; 39 - } 40 - 41 9 .phui-box.phui-box-grey.project-view-properties { 42 10 margin: 0 16px 0 16px; 43 11 padding: 4px 12px; 12 + } 13 + 14 + .device-phone .phui-box.phui-box-grey.project-view-properties { 15 + margin: 0 12px 0 12px; 44 16 } 45 17 46 18 .project-view-properties .phui-property-list-key {
+37
webroot/rsrc/css/phui/phui-header-view.css
··· 253 253 .phui-header-subheader .phui-badge-flex-view:after { 254 254 display: inline; 255 255 } 256 + 257 + /*** Profile Header ***********************************************************/ 258 + 259 + .phui-profile-header { 260 + padding: 24px 20px 20px 24px; 261 + } 262 + 263 + .device-phone .phui-profile-header { 264 + padding: 12px; 265 + } 266 + 267 + .phui-profile-header.phui-header-shell { 268 + margin: 0; 269 + border: none; 270 + } 271 + 272 + .phui-profile-header .phui-header-image { 273 + height: 80px; 274 + width: 80px; 275 + } 276 + 277 + .phui-profile-header .phui-header-col1 { 278 + width: 96px; 279 + } 280 + 281 + .phui-profile-header .phui-header-subheader { 282 + margin-top: 12px; 283 + } 284 + 285 + .phui-profile-header.phui-header-shell .phui-header-header { 286 + font-family: 'Aleo', {$fontfamily}; 287 + font-size: 24px; 288 + } 289 + 290 + .phui-profile-header .phui-header-col3 { 291 + vertical-align: top; 292 + }