@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Attribute revision promotion from "Draft" to "Needs Review" to the author
Summary:
Ref T2543. When Harbormaster finishes builds and promotes a draft revision to review, we currently publish "Harbormaster requested review of...".
Instead, attribute this action to the author, since that's more natural and more useful.
Test Plan: Promoted a diff locally, saw it attributed to me rather than Harbormaster.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T2543
Differential Revision: https://secure.phabricator.com/D18730
+6
+6
src/applications/differential/editor/DifferentialTransactionEditor.php
+6
src/applications/differential/editor/DifferentialTransactionEditor.php
···
1537
1537
if ($object->isDraft() && $auto_undraft) {
1538
1538
$active_builds = $this->hasActiveBuilds($object);
1539
1539
if (!$active_builds) {
1540
+
// When Harbormaster moves a revision out of the draft state, we
1541
+
// attribute the action to the revision author since this is more
1542
+
// natural and more useful.
1543
+
$author_phid = $object->getAuthorPHID();
1544
+
1540
1545
$xaction = $object->getApplicationTransactionTemplate()
1546
+
->setAuthorPHID($author_phid)
1541
1547
->setTransactionType(
1542
1548
DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE)
1543
1549
->setOldValue(false)