@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Slowvote transactions a little
Summary: Ref T12685. Moves to `xaction` folder and sets description changes in transaction stories.
Test Plan: Make a poll, edit the description.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12685
Differential Revision: https://secure.phabricator.com/D17849
+17
-11
+6
-6
src/__phutil_library_map__.php
+6
-6
src/__phutil_library_map__.php
···
3912
3912
'PhabricatorSlowvoteApplication' => 'applications/slowvote/application/PhabricatorSlowvoteApplication.php',
3913
3913
'PhabricatorSlowvoteChoice' => 'applications/slowvote/storage/PhabricatorSlowvoteChoice.php',
3914
3914
'PhabricatorSlowvoteCloseController' => 'applications/slowvote/controller/PhabricatorSlowvoteCloseController.php',
3915
-
'PhabricatorSlowvoteCloseTransaction' => 'applications/slowvote/xactions/PhabricatorSlowvoteCloseTransaction.php',
3915
+
'PhabricatorSlowvoteCloseTransaction' => 'applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php',
3916
3916
'PhabricatorSlowvoteCommentController' => 'applications/slowvote/controller/PhabricatorSlowvoteCommentController.php',
3917
3917
'PhabricatorSlowvoteController' => 'applications/slowvote/controller/PhabricatorSlowvoteController.php',
3918
3918
'PhabricatorSlowvoteDAO' => 'applications/slowvote/storage/PhabricatorSlowvoteDAO.php',
3919
3919
'PhabricatorSlowvoteDefaultViewCapability' => 'applications/slowvote/capability/PhabricatorSlowvoteDefaultViewCapability.php',
3920
-
'PhabricatorSlowvoteDescriptionTransaction' => 'applications/slowvote/xactions/PhabricatorSlowvoteDescriptionTransaction.php',
3920
+
'PhabricatorSlowvoteDescriptionTransaction' => 'applications/slowvote/xaction/PhabricatorSlowvoteDescriptionTransaction.php',
3921
3921
'PhabricatorSlowvoteEditController' => 'applications/slowvote/controller/PhabricatorSlowvoteEditController.php',
3922
3922
'PhabricatorSlowvoteEditor' => 'applications/slowvote/editor/PhabricatorSlowvoteEditor.php',
3923
3923
'PhabricatorSlowvoteListController' => 'applications/slowvote/controller/PhabricatorSlowvoteListController.php',
···
3927
3927
'PhabricatorSlowvotePollController' => 'applications/slowvote/controller/PhabricatorSlowvotePollController.php',
3928
3928
'PhabricatorSlowvotePollPHIDType' => 'applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php',
3929
3929
'PhabricatorSlowvoteQuery' => 'applications/slowvote/query/PhabricatorSlowvoteQuery.php',
3930
-
'PhabricatorSlowvoteQuestionTransaction' => 'applications/slowvote/xactions/PhabricatorSlowvoteQuestionTransaction.php',
3930
+
'PhabricatorSlowvoteQuestionTransaction' => 'applications/slowvote/xaction/PhabricatorSlowvoteQuestionTransaction.php',
3931
3931
'PhabricatorSlowvoteReplyHandler' => 'applications/slowvote/mail/PhabricatorSlowvoteReplyHandler.php',
3932
-
'PhabricatorSlowvoteResponsesTransaction' => 'applications/slowvote/xactions/PhabricatorSlowvoteResponsesTransaction.php',
3932
+
'PhabricatorSlowvoteResponsesTransaction' => 'applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php',
3933
3933
'PhabricatorSlowvoteSchemaSpec' => 'applications/slowvote/storage/PhabricatorSlowvoteSchemaSpec.php',
3934
3934
'PhabricatorSlowvoteSearchEngine' => 'applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php',
3935
-
'PhabricatorSlowvoteShuffleTransaction' => 'applications/slowvote/xactions/PhabricatorSlowvoteShuffleTransaction.php',
3935
+
'PhabricatorSlowvoteShuffleTransaction' => 'applications/slowvote/xaction/PhabricatorSlowvoteShuffleTransaction.php',
3936
3936
'PhabricatorSlowvoteTransaction' => 'applications/slowvote/storage/PhabricatorSlowvoteTransaction.php',
3937
3937
'PhabricatorSlowvoteTransactionComment' => 'applications/slowvote/storage/PhabricatorSlowvoteTransactionComment.php',
3938
3938
'PhabricatorSlowvoteTransactionQuery' => 'applications/slowvote/query/PhabricatorSlowvoteTransactionQuery.php',
3939
-
'PhabricatorSlowvoteTransactionType' => 'applications/slowvote/xactions/PhabricatorSlowvoteTransactionType.php',
3939
+
'PhabricatorSlowvoteTransactionType' => 'applications/slowvote/xaction/PhabricatorSlowvoteTransactionType.php',
3940
3940
'PhabricatorSlowvoteVoteController' => 'applications/slowvote/controller/PhabricatorSlowvoteVoteController.php',
3941
3941
'PhabricatorSlug' => 'infrastructure/util/PhabricatorSlug.php',
3942
3942
'PhabricatorSlugTestCase' => 'infrastructure/util/__tests__/PhabricatorSlugTestCase.php',
src/applications/slowvote/xactions/PhabricatorSlowvoteCloseTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteCloseTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php
+11
-5
src/applications/slowvote/xactions/PhabricatorSlowvoteDescriptionTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteDescriptionTransaction.php
+11
-5
src/applications/slowvote/xactions/PhabricatorSlowvoteDescriptionTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteDescriptionTransaction.php
···
36
36
}
37
37
}
38
38
39
-
public function hasChangeDetails() {
39
+
public function hasChangeDetailView() {
40
40
return true;
41
41
}
42
42
43
+
public function getMailDiffSectionHeader() {
44
+
return pht('CHANGES TO POLL DESCRIPTION');
45
+
}
46
+
43
47
public function newChangeDetailView() {
44
-
return $this->renderTextCorpusChangeDetails(
45
-
$this->getViewer(),
46
-
$this->getOldValue(),
47
-
$this->getNewValue());
48
+
$viewer = $this->getViewer();
49
+
50
+
return id(new PhabricatorApplicationTransactionTextDiffDetailView())
51
+
->setViewer($viewer)
52
+
->setOldText($this->getOldValue())
53
+
->setNewText($this->getNewValue());
48
54
}
49
55
50
56
public function newRemarkupChanges() {
src/applications/slowvote/xactions/PhabricatorSlowvoteQuestionTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteQuestionTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteQuestionTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteQuestionTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteResponsesTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteResponsesTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteShuffleTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteShuffleTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteShuffleTransaction.php
src/applications/slowvote/xaction/PhabricatorSlowvoteShuffleTransaction.php
src/applications/slowvote/xactions/PhabricatorSlowvoteTransactionType.php
src/applications/slowvote/xaction/PhabricatorSlowvoteTransactionType.php
src/applications/slowvote/xactions/PhabricatorSlowvoteTransactionType.php
src/applications/slowvote/xaction/PhabricatorSlowvoteTransactionType.php