@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up remaining default column logic for boards
Summary: See D10189. We should never hit this anymore, so clean it up.
Test Plan:
- Reloaded a board, saw everything stay where it was before the change.
- Added a new task to the project, saw it show up in backlog.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D10200
+7
-7
+7
-7
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+7
-7
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
166
166
}
167
167
168
168
$task_map = array();
169
-
$default_phid = $columns[0]->getPHID();
170
169
foreach ($tasks as $task) {
171
170
$task_phid = $task->getPHID();
172
-
173
-
$column_phid = null;
174
-
if (isset($positions[$task_phid])) {
175
-
$column_phid = $positions[$task_phid]->getColumnPHID();
171
+
if (empty($positions[$task_phid])) {
172
+
// This shouldn't normally be possible because we create positions on
173
+
// demand, but we might have raced as an object was removed from the
174
+
// board. Just drop the task if we don't have a position for it.
175
+
continue;
176
176
}
177
-
$column_phid = nonempty($column_phid, $default_phid);
178
177
179
-
$task_map[$column_phid][] = $task_phid;
178
+
$position = $positions[$task_phid];
179
+
$task_map[$position->getColumnPHID()][] = $task_phid;
180
180
}
181
181
182
182
// If we're showing the board in "natural" order, sort columns by their