Move "Wait for Previous Commits to Build" out of prototype

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan: Added a new build step, saw this as an option in the "Flow Control" section.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D21432

epriestley 5 years ago c1eeacd8 017ef192

+1 -1

1 changed file

expand all

src

applications

harbormaster

step

HarbormasterWaitForPreviousBuildStepImplementation.php

+1 -1

src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php

··· 14 14 } 15 15 16 16 public function getBuildStepGroupKey() { 17 - return HarbormasterPrototypeBuildStepGroup::GROUPKEY; 17 + return HarbormasterControlBuildStepGroup::GROUPKEY; 18 18 } 19 19 20 20 public function execute(

Configure Feed

Configure Feed